Add x86 paging rt test #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrDeano
reviewed
Sep 9, 2019
|
We should wait until my 4kb paging PR is merged so I can add some new paging tests to this PR. |
SamTebbs33
force-pushed
the
feature/paging-rt-tests
branch
from
9ccb898
to
5808195
Compare
5 tasks
|
Ready for review again. |
SamTebbs33
force-pushed
the
feature/paging-rt-tests
branch
from
5808195
to
61e3895
Compare
SamTebbs33
force-pushed
the
feature/paging-rt-tests
branch
from
e031577
to
591599b
Compare
DrDeano
reviewed
Oct 1, 2019
src/kernel/arch/x86/paging.zig
Outdated
| const tty_addr = tty.getVideoBufferAddress(); | ||
| // If the previous mappping space didn't cover the tty buffer, do so now | ||
| if (v_start > tty_addr or v_end <= tty_addr) { | ||
| const tty_phys = virtToPhys(tty_addr); | ||
| const tty_buff_size = 32 * 1024; | ||
| mapDir(kernel_directory, tty_addr, tty_addr + tty_buff_size, tty_phys, tty_phys + tty_buff_size, allocator) catch panic(@errorReturnTrace(), "Failed to map vga buffer in kernel directory"); | ||
| mapDir(kernel_directory, tty_addr, tty_addr + tty_buff_size, tty_phys, tty_phys + tty_buff_size, allocator) catch |e| panic(@errorReturnTrace(), "Failed to map vga buffer in kernel directory: {}", @errorName(e)); |
There was a problem hiding this comment.
You don't need the @errorName as fmt handles it for you. Also (u may reject), so the line isn't long, have this like:
mapDir(kernel_directory, tty_addr, tty_addr + tty_buff_size, tty_phys, tty_phys + tty_buff_size, allocator) catch |e| {
panic(@errorReturnTrace(), "Failed to map vga buffer in kernel directory: {}\n", e);
};Also for the other error printing.
Also add new lines (\n) to the end of the logging.
SamTebbs33
force-pushed
the
feature/paging-rt-tests
branch
from
acfcf5d
to
fc10dbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a runtime test to x86 paging which ensures that unmapped memory causes a page fault. If you can think of any other tests I could add please say so. Part of #60