Skip to content

Latest commit

 

History

History
executable file
·
43 lines (22 loc) · 1.82 KB

CONTRIBUTING.md

File metadata and controls

executable file
·
43 lines (22 loc) · 1.82 KB
Raw

Contributing

Contributions are welcome and will be fully credited.

We accept contributions via Pull Requests on Github.

Pull Requests

  • PSR-2 Coding Standard - Unlike Laravel, the LaravelFacebookSdk follows PSR-2. The easiest way to apply the conventions is to install PHP Code Sniffer.

  • Add tests! - Your patch won't be accepted if it doesn't have tests. And the tests must pass of course.

  • Document any change in behavior - Make sure the README and any other relevant documentation are kept up-to-date.

  • Consider our release cycle - We try to follow semver. Randomly breaking public APIs is not an option.

  • Create topic branches - Don't ask us to pull from your master branch.

  • One pull request per feature - If you want to do more than one thing, send multiple pull requests.

  • Send coherent history - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please squash them before submitting.

  • Ensure tests pass! - Please run the tests (see below) before submitting your pull request, and make sure they pass. We won't accept a patch until all tests pass.

  • Ensure no coding standards violations - Please run PHP Code Sniffer using the PSR-2 standard (see below) before submitting your pull request. A violation will cause the build to fail, so please make sure there are no violations. We can't accept a patch if the build fails.

Running Tests

$ ./vendor/bin/phpunit

Running PHP Code Sniffer

$ ./vendor/bin/phpcs src --standard=psr2 -sp

Happy coding!