Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building and running Chromium GStreamer backend within gst-uninstalled environment #1

Closed
JulienIsorce opened this issue Jun 30, 2015 · 1 comment
Closed

Support building and running Chromium GStreamer backend within gst-uninstalled environment #1

JulienIsorce opened this issue Jun 30, 2015 · 1 comment
Labels
enhancement

Comments

@JulienIsorce
Copy link
Contributor

gst-uninstalled tutorial: http://arunraghavan.net/2014/07/quick-start-guide-to-gst-uninstalled-1-x/

To build ChromiumGStreamerBackend within gst-uninstalled env this gst bug needs to be fixed: https://bugzilla.gnome.org/show_bug.cgi?id=720778

Running ChromiumGStreamerBackend with sandbox within gst-uninstalled env, is working since this patch: 92f3f81
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@GregTho @JulienIsorce
Revert of Pretty print AlternativeService in test macros. (patchset #1 …
0d0d210 
…id:1 of https://codereview.chromium.org/1212813006/)

Reason for revert:
Introduced new static initializers:

# http_server_properties.cc _GLOBAL__sub_I_http_server_properties.cc+0x10
# http_server_properties.cc std::ios_base::Init::Init()@plt
# http_server_properties.cc __cxa_atexit@plt [registers a dtor to run at exit]

Original issue's description:
> Pretty print AlternativeService in test macros.
>
> Implement operator<<(std::ostream&, const AlternativeService&) so that when
> EXPECT_EQ or ASSERT_EQ fails between two AlternativeService structs, the test
> output contains protocol names and hostnames pretty printed, instead of a binary
> blob including useless things like the memory address of where std::string
> stores the hostname.
>
> Currently used in AlternateProtocolServerPropertiesTest.BrokenShadowsCanonical
> only, but more tests involving EXPECT_EQ between AlternativeService structs are
> coming.
>
> BUG=392575
>
> Committed: https://crrev.com/a3542c2eb9d3760800d718c51eb9f573a42c6b42
> Cr-Commit-Position: refs/heads/master@{#336551}

TBR=rch@chromium.org,bnc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=392575

Review URL: https://codereview.chromium.org/1218813005

Cr-Commit-Position: refs/heads/master@{#336556}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@GregTho @JulienIsorce
Revert of Revert of content: Fix single process support for native Gp…
e95e2d2 
…uMemoryBuffers. (patchset #1 id:1 of https://codereview.chromium.org/1210073003/)

Reason for revert:
Reverting the revert since this wasn't the problem after all.

Original issue's description:
> Revert of content: Fix single process support for native GpuMemoryBuffers. (patchset #1 id:1 of https://codereview.chromium.org/1221473003/)
>
> Reason for revert:
> XP_tests started failing with "missing shard" exceptions. Suspect this cl.
>
> https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/38438
>
> Original issue's description:
> > content: Fix single process support for native GpuMemoryBuffers.
> >
> > Also add the startup message filter for CreateGpuMemoryBuffer
> > messages in single process mode.
> >
> > BUG=497559,504121
> >
> > Committed: https://crrev.com/29ec87df6cef29b9f28dd21d385f16ce99df9ce3
> > Cr-Commit-Position: refs/heads/master@{#336495}
>
> TBR=piman@chromium.org,reveman@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=497559,504121
>
> Committed: https://crrev.com/1cf221f6cebc8850220100c24d00a18ad54bfe8d
> Cr-Commit-Position: refs/heads/master@{#336531}

TBR=piman@chromium.org,reveman@chromium.org,kcarattini@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497559,504121

Review URL: https://codereview.chromium.org/1218783003

Cr-Commit-Position: refs/heads/master@{#336593}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Revert of Disabled two IPC messages on ChromeOS (patchset #1 id:1 of h…
4ae8732 
…ttps://codereview.chromium.org/1221523002/)

Reason for revert:
Likely broke ChromiumOS build:

../../components/printing/test/print_web_view_helper_browsertest.cc: In member function 'void printing::PrintWebViewHelperTestBase::VerifyPagesPrinted(bool)':
../../components/printing/test/print_web_view_helper_browsertest.cc:198:14: error: 'PrintHostMsg_TempFileForPrintingWritten' has not been declared
              PrintHostMsg_TempFileForPrintingWritten::ID) != NULL);

Original issue's description:
> Disabled two IPC messages on ChromeOS
>
> PrintHostMsg_AllocateTempFileForPrinting and
> PrintHostMsg_TempFileForPrintingWritten were used only
> by Cloud Print Dialog.
>
> BUG=408684
>
> Committed: https://crrev.com/3401f2836863aaee76e2115bc502820a149774c9
> Cr-Commit-Position: refs/heads/master@{#336614}

TBR=inferno@chromium.org,jschuh@chromium.org,nasko@chromium.org,vitalybuka@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=408684

Review URL: https://codereview.chromium.org/1214183005

Cr-Commit-Position: refs/heads/master@{#336633}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Roll src/third_party/skia 91b6f32:c845fa0
8e5d743 
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/91b6f32..c845fa0

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Commits in this roll:
c845fa0 mtklein@chromium.org Pass arguments to SkRecords structs by const&.
439f23e jvanverth@google.com Revert of Cleanup legacy NVPR-related definitions (patchset #4 id:60001 of https://codereview.chromium.org/1177243004/)
73bb435 bsalomon@google.com Remove default for --images in common flags
16857e4 rmistry@google.com Use AddStory instead of deprecated AddUserStory
ffe6ebb bsalomon@google.com Fix blur bug on Andreno 430 with bool cast to float
8f74c16 rmistry@google.com Revert of Use page_set_module.PageSet instead of story.StorySet (patchset #1 id:1 of https://codereview.chromium.org/1221553003/)
962cc98 joshualitt@chromium.org Add benchmarkstream to visualbench
2757e3f bsalomon@google.com Update blur image filter bench to have crop variation
98fc73c sammc@chromium.org Change initializer list order to match field declaration order.

Review URL: https://codereview.chromium.org/1218023005

Cr-Commit-Position: refs/heads/master@{#336841}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Roll src/third_party/skia d3e259a:19fb80e
f474745 
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d3e259a..19fb80e

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Commits in this roll:
19fb80e herb@google.com Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (patchset #1 id:1 of https://codereview.chromium.org/1213033003/)
dec1afc herb@google.com Add annotations to SkSharedMutex.
a8d4559 vmpstr@chromium.org Fix infinite matrix during an invert.
7f6283b msarett@google.com Fix CodecSubset benches seg faults for kIndex8

Review URL: https://codereview.chromium.org/1216293003

Cr-Commit-Position: refs/heads/master@{#336918}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Revert of Make task manager memory data more efficient and meaningful…
d87c32f 
…. (patchset #16 id:300001 of https://codereview.chromium.org/1181263005/)

Reason for revert:
This appears to have triggered a unit test failure on the vista bot.
https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/57386
output:
(view as text)
PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (run #1):
[ RUN      ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(32): error: Expected: (private_ws) > (2000000u), actual: 0 vs 2000000
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(50): error: Expected: (private_ws3) > (private_ws2 + alloc_size / 2), actual: 0 vs 5000000
GetPrivateWorkingSet should increase as we allocate more memory
[  FAILED  ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (78 ms)

PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (run #2):
[ RUN      ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(32): error: Expected: (private_ws) > (2000000u), actual: 0 vs 2000000
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(50): error: Expected: (private_ws3) > (private_ws2 + alloc_size / 2), actual: 0 vs 5000000
GetPrivateWorkingSet should increase as we allocate more memory
[  FAILED  ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (47 ms)

PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (run #3):
[ RUN      ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(32): error: Expected: (private_ws) > (2000000u), actual: 0 vs 2000000
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(50): error: Expected: (private_ws3) > (private_ws2 + alloc_size / 2), actual: 0 vs 5000000
GetPrivateWorkingSet should increase as we allocate more memory
[  FAILED  ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (47 ms)

PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (run #4):
[ RUN      ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(32): error: Expected: (private_ws) > (2000000u), actual: 0 vs 2000000
c:\b\build\slave\win_builder\build\src\chrome\browser\private_working_set_snapshot_win_unittest.cc(50): error: Expected: (private_ws3) > (private_ws2 + alloc_size / 2), actual: 0 vs 5000000
GetPrivateWorkingSet should increase as we allocate more memory
[  FAILED  ] PrivateWorkingSetSnapshotWinTest.FindPidSelfTest (47 ms)

Original issue's description:
> Make task manager memory data more efficient and meaningful.
>
> Chrome's default memory column is quite expensive to calculate. The
> Windows version of ProcessMetrics::GetWorkingSetKBytes uses QueryWorkingSet
> which returns information for every page in the process. Generating and
> copying this data is expensive enough that it can lead to 100+ ms hitches
> in scrolling, which also means that it is consuming 10% of a core (100 ms
> for every per-second update). That is with about 20 tabs open and the cost
> increases proportionally with more tabs. See bug 494210
>
> Chrome's default memory column also does not display the best possible
> number. Because it includes shareable-but-not-shared memory it means that
> renderer code goes from being counted when one tab is open to being not
> count when two tabs are open. This causes confusion. Proportional Set Size
> could avoid this confusion but is non-standard for Windows. Private working
> set is a better choice because it has a clear meaning and is a standard
> memory column in task manager and process explorer. See bug 484433
>
> This change adds a RefreshPhysicalMemoryFromWorkingSetSnapshot step to
> TaskManagerModel::Refresh. After the old data has been thrown away the
> RefreshPhysicalMemoryFromWorkingSetSnapshot function uses Pdh to
> retrieve private working set data for all chrome processes. Then when
> TaskManagerModel::GetPhysicalMemory is called it will almost always find
> that values.is_physical_memory_valid is already true. Because Pdh retrieves
> all private working sets in one call, from the private-to-Windows memory
> bookkeeping data, this is much faster than calculating working sets for
> each process individually and the cost is mostly independent of the number
> of processes.
>
> Therefore the speedup from using Pdh increases with more tabs. If the user
> has one small tab open then Pdh is slightly faster. With three tabs open
> Pdh is significantly faster. With six tabs (eight processes) Pdh is nine
> times faster than using QueryWorkingSet (0.18 ms per process versus 1.6 ms
> per process).
>
> GetPhysicalMemory has been modified to subtract shareable from the
> physical_memory instead of shared so that it also calculates private
> working set, for consistency. This change is a NOP on OSX because shared
> and shareable are both always zero (see GetCommittedAndWorkingSetKBytes in
> process_metrics_mac.cc).
>
> In the cases where Pdh fails or a new chrome process is created between
> RefreshPhysicalMemoryFromWorkingSetSnapshot and GetPhysicalMemory the
> GetPhysicalMemory calculations will be used. The results typically differ by
> less than 0.5%. Alternating between the two methods on each refresh shows no
> significant change.
>
> Pdh supports retrieving private working set data on Vista and above. On
> Windows XP the code will fall-back to using the old method.
>
> Pdh will return private WS data for all chrome* processes, so canary and
> stable will see each other's processes, but
> RefreshPhysicalMemoryFromWorkingSetSnapshot will ignore unrelated processes.
> Processes with names like 'chromeWidget.exe' will also be listed and will
> also be ignored. This does not measurably affect performance.
>
> R=nick@chromium.org,jschuh@chromium.org,rsesek@chromium.org,thakis@chromium.org
> BUG=484433,494210
>
> Committed: https://crrev.com/f66d1ecf0cd7426393088c91f2af78ff1889bab4
> Cr-Commit-Position: refs/heads/master@{#337096}

TBR=nick@chromium.org,jschuh@chromium.org,rsesek@chromium.org,thakis@chromium.org,brucedawson@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484433,494210

Review URL: https://codereview.chromium.org/1219233002

Cr-Commit-Position: refs/heads/master@{#337117}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@danbeam @JulienIsorce
Revert of Fix closure compile after https://codereview.chromium.org/1…
83e7dcb 
…212653010/ (patchset #1 id:1 of https://codereview.chromium.org/1213063010/)

Reason for revert:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/2553

Original issue's description:
> Fix closure compile after https://codereview.chromium.org/1212653010/
>
> TBR=yoshiki@chromium.org
> BUG=none
> TEST=green closure compiler bots
>
> Committed: https://crrev.com/d3cb15365f7cca8be2d794be25be88f6a72771a4
> Cr-Commit-Position: refs/heads/master@{#337092}

TBR=yoshiki@chromium.org,smckay@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1218783009

Cr-Commit-Position: refs/heads/master@{#337124}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@danbeam @JulienIsorce
Revert of Revert of Fix closure compile after https://codereview.chro…
eea1606 
…mium.org/1212653010/ (patchset #1 id:1 of https://codereview.chromium.org/1218783009/)

Reason for revert:
The MSan bots just seem to be flaky.  They were fixed before picking up my revert :(.

Original issue's description:
> Revert of Fix closure compile after https://codereview.chromium.org/1212653010/ (patchset #1 id:1 of https://codereview.chromium.org/1213063010/)
>
> Reason for revert:
> http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/2553
>
> Original issue's description:
> > Fix closure compile after https://codereview.chromium.org/1212653010/
> >
> > TBR=yoshiki@chromium.org
> > BUG=none
> > TEST=green closure compiler bots
> >
> > Committed: https://crrev.com/d3cb15365f7cca8be2d794be25be88f6a72771a4
> > Cr-Commit-Position: refs/heads/master@{#337092}
>
> TBR=yoshiki@chromium.org,smckay@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
>
> Committed: https://crrev.com/69033adfca97ce4d96593cfabf091723231b992b
> Cr-Commit-Position: refs/heads/master@{#337124}

TBR=yoshiki@chromium.org,smckay@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1226433002

Cr-Commit-Position: refs/heads/master@{#337143}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@hirono-chromium @JulienIsorce
Gallery: Fix race bug of RAW image loading.
e24033d 
Previously Gallery could invokes setTimeout with null callback function.

1. Load RAW image.
2. Cancel it.
3. Load another image.
4. Receive error for the request of #1. Clear completion callback.
5. Receive load complete event for the request of #3. Invokes null completion
   callback.

BUG=504622
TEST=None

Review URL: https://codereview.chromium.org/1220123002

Cr-Commit-Position: refs/heads/master@{#337195}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Revert of Reland: Optimizes IndexedDB's DeleteDatabase when no db exi…
5be68dc 
…sts (patchset #1 id:1 of https://codereview.chromium.org/1216573008/)

Reason for revert:
Some bots still flaky. See crbug.com/506467

Original issue's description:
> Reland: Optimizes IndexedDB's DeleteDatabase when no db exists
>
> When deleting the non existing database in a origin with no existing
> backing store, then in DeleteDatabse(), early exiting before
> OpenBackingStore, so that it wont results in multiple transaction as
> earlier.
>
> Original patch by: payal.pandey
>
> This was reverted (see crrev.com/1071553002) when it appeared to make
> a test flaky, but the test continues to flake (now tracked as
> crbug.com/505609) so let's try relanding.
>
> BUG=460236
>
> Committed: https://crrev.com/4cbc8f1b383fb8145056295176912d53030a98b0
> Cr-Commit-Position: refs/heads/master@{#336796}

TBR=cmumford@chromium.org,jsbell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460236

Review URL: https://codereview.chromium.org/1225513002

Cr-Commit-Position: refs/heads/master@{#337228}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Revert of Revert of Reland: Optimizes IndexedDB's DeleteDatabase when…
b437213 
… no db exists (patchset #1 id:1 of https://codereview.chromium.org/1225513002/)

Reason for revert:
Test is still flaky.

Original issue's description:
> Revert of Reland: Optimizes IndexedDB's DeleteDatabase when no db exists (patchset #1 id:1 of https://codereview.chromium.org/1216573008/)
>
> Reason for revert:
> Some bots still flaky. See crbug.com/506467
>
> Original issue's description:
> > Reland: Optimizes IndexedDB's DeleteDatabase when no db exists
> >
> > When deleting the non existing database in a origin with no existing
> > backing store, then in DeleteDatabse(), early exiting before
> > OpenBackingStore, so that it wont results in multiple transaction as
> > earlier.
> >
> > Original patch by: payal.pandey
> >
> > This was reverted (see crrev.com/1071553002) when it appeared to make
> > a test flaky, but the test continues to flake (now tracked as
> > crbug.com/505609) so let's try relanding.
> >
> > BUG=460236
> >
> > Committed: https://crrev.com/4cbc8f1b383fb8145056295176912d53030a98b0
> > Cr-Commit-Position: refs/heads/master@{#336796}
>
> TBR=cmumford@chromium.org,jsbell@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=460236
>
> Committed: https://crrev.com/4e132285cadc8875bd8bf5d0078f325562fdd620
> Cr-Commit-Position: refs/heads/master@{#337228}

TBR=cmumford@chromium.org,jsbell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460236

Review URL: https://codereview.chromium.org/1224533004

Cr-Commit-Position: refs/heads/master@{#337231}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Clean up src-side runtest.py, patch #1
e95fd11 
BUG=506498

Review URL: https://codereview.chromium.org/1226603002

Cr-Commit-Position: refs/heads/master@{#337302}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Roll src/third_party/skia 4417c7f:8355100
6175b7e 
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4417c7f..8355100

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Commits in this roll:
8355100 jvanverth@google.com Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1219193002/)
2853fe4 jvanverth@google.com Revert of Implement support for CHROMIUM_path_rendering pseudo extension (patchset #4 id:60001 of https://codereview.chromium.org/1192663002/)
94a2fbc jvanverth@google.com Revert of Switch SkJpegCode to libjpeg-turbo (patchset #29 id:750001 of https://codereview.chromium.org/1180983002/)
6c90e09 jvanverth@google.com Revert of Fixing libpng transform use  (patchset #5 id:80001 of https://codereview.chromium.org/1214203005/)
f1b44cb jvanverth@google.com Revert of Fix libjpeg-turbo deps file (patchset #2 id:2 of https://codereview.chromium.org/1216303007/)
02802f6 jvanverth@google.com Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/)
eeef46d kkinnunen@nvidia.com Implement support for CHROMIUM_path_rendering pseudo extension
4380f06 msarett@google.com Fix libjpeg-turbo deps file
42126db msarett@google.com whitespace
9693037 emmaleer@google.com This change: - supports kGray correctly - avoid extra call to png_get_IHDR by storing the bit depth - call transforms as needed - checks for tRNS alpha value in RGB and GRAY color types
40141b5 msarett@google.com Add libjpeg-turbo library (depends on yasm) Mangle external function names to avoid conflict with libjpeg Take advantage of direct color conversion (RGBA, BGRA, 565) Prepare to use jpeg_skip_scanlines (when it is upstreamed)
c50acf2 mtklein@chromium.org Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.
64b4c78 mtklein@chromium.org Add support for drawBitmapRect() to SkMiniRecorder.
478c9e4 mtklein@google.com Revert "Move headers used by headers in include/ to include/private."
aa2a7de msarett@google.com Revert of Switch SkJpegCode to libjpeg-turbo (patchset #28 id:710001 of https://codereview.chromium.org/1180983002/)
a760942 mtklein@chromium.org Don't cap num_cores at 32 on 32-bit Windows.
74a07db joshualitt@chromium.org cleanup GLBenches
e9e3ee3 msarett@google.com Add libjpeg-turbo library (depends on yasm) Mangle external function names to avoid conflict with libjpeg Take advantage of direct color conversion (RGBA, BGRA, 565) Prepare to use jpeg_skip_scanlines (when it is upstreamed)
928e165 mtklein@chromium.org Move headers used by headers in include/ to include/private.
ebaf6a6 bsalomon@google.com Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2 id:30001 of https://codereview.chromium.org/1210053003/)

Review URL: https://codereview.chromium.org/1217423003

Cr-Commit-Position: refs/heads/master@{#337313}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@nico @JulienIsorce
Revert of Try harder to work around a clang/win bug. (patchset #1 id:…
e43ae54 
…1 of https://codereview.chromium.org/1208103006/)

Reason for revert:
Looks like this is unnecessary; the first CL did the trick already.

Original issue's description:
> Try harder to work around a clang/win bug.
>
> This is a follow-up to https://codereview.chromium.org/1215613006
> which didn't help.
>
> BUG=BUG=488634
> TBR=jkarlin@chromium.org

TBR=jkarlin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=BUG=488634

Review URL: https://codereview.chromium.org/1221433004

Cr-Commit-Position: refs/heads/master@{#337338}
JulienIsorce pushed a commit that referenced this issue Jul 10, 2015
@JulienIsorce
Revert of Convert ppapi_unittests to run exclusively on Swarming (pat…
ec2bcd3 
…chset #1 id:1 of https://codereview.chromium.org/1224453003/)

Reason for revert:
Results in multiple data races reported on ppapi_unittests by ThreadSanitizer

Original issue's description:
> Convert ppapi_unittests to run exclusively on Swarming
>
> 0 configs already ran on Swarming
> 46 used to run locally and were converted:
> - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1)
> - chromium.chromiumos.json: Linux ChromiumOS Tests (1)
> - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1)
> - chromium.fyi.json: ClangToTLinux tester
> - chromium.fyi.json: ClangToTLinuxASan tester
> - chromium.fyi.json: ClangToTMac tester
> - chromium.fyi.json: ClangToTMacASan tester
> - chromium.fyi.json: ClangToTWin tester
> - chromium.fyi.json: ClangToTWin(dbg) tester
> - chromium.fyi.json: ClangToTWin(dll) tester
> - chromium.fyi.json: ClangToTWin64 tester
> - chromium.fyi.json: ClangToTWin64(dbg) tester
> - chromium.fyi.json: ClangToTWin64(dll) tester
> - chromium.fyi.json: CrWinAsan tester
> - chromium.fyi.json: CrWinAsan(dll) tester
> - chromium.fyi.json: CrWinClang tester
> - chromium.fyi.json: CrWinClang(dbg) tester
> - chromium.fyi.json: CrWinClang(shared) tester
> - chromium.fyi.json: CrWinClang64 tester
> - chromium.fyi.json: CrWinClang64(dbg) tester
> - chromium.fyi.json: CrWinClang64(dll) tester
> - chromium.fyi.json: CrWinClangLLD tester
> - chromium.fyi.json: Linux Trusty
> - chromium.fyi.json: Linux Trusty (dbg)
> - chromium.linux.json: Cast Linux
> - chromium.linux.json: Linux Tests
> - chromium.linux.json: Linux Tests (dbg)(1)
> - chromium.linux.json: Linux Tests (dbg)(1)(32)
> - chromium.mac.json: Mac10.10 Tests
> - chromium.mac.json: Mac10.6 Tests
> - chromium.mac.json: Mac10.8 Tests
> - chromium.mac.json: Mac10.9 Tests
> - chromium.mac.json: Mac10.9 Tests (dbg)
> - chromium.memory.fyi.json: Linux ChromeOS MSan Tests
> - chromium.memory.fyi.json: Linux MSan Tests
> - chromium.memory.fyi.json: Linux TSan Tests
> - chromium.memory.json: Linux ASan LSan Tests (1)
> - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1)
> - chromium.memory.json: Mac ASan 64 Tests (1)
> - chromium.webkit.json: Linux ChromiumOS Tests (1)
> - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1)
> - chromium.win.json: Vista Tests (1)
> - chromium.win.json: Win 7 Tests x64 (1)
> - chromium.win.json: Win7 Tests (1)
> - chromium.win.json: Win7 Tests (dbg)(1)
> - chromium.win.json: XP Tests (1)
>
> Ran:
>   ./manage.py --convert ppapi_unittests
>
> BUG=98637
>
> Committed: https://crrev.com/0e660cb50e66dc9d5e794d63b4bd72079acefc2e
> Cr-Commit-Position: refs/heads/master@{#337272}

TBR=raymes@chromium.org,maruel@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637

Review URL: https://codereview.chromium.org/1218743005

Cr-Commit-Position: refs/heads/master@{#337347}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@JulienIsorce
Roll src/third_party/skia 11271fe:d390110
8518e9c 
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/11271fe..d390110

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=stephana@google.com

Commits in this roll:
d390110 fmalita@chromium.org Use kLow_SkFilterQuality in DrawBitmapAABench
d312dca robertphillips@google.com Revert of Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1207353004/)

Review URL: https://codereview.chromium.org/1226833003

Cr-Commit-Position: refs/heads/master@{#337410}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@JulienIsorce
Revert of Convert ipc_mojo_unittests to run exclusively on Swarming (…
82e03b1 
…patchset #1 id:1 of https://codereview.chromium.org/1222243003/)

Reason for revert:
Results in data races on ThreadSanitizer MFYI bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/6970

Original issue's description:
> Convert ipc_mojo_unittests to run exclusively on Swarming
>
> 0 configs already ran on Swarming
> 8 used to run locally and were converted:
> - chromium.linux.json: Android GN
> - chromium.linux.json: Linux Tests
> - chromium.linux.json: Linux Tests (dbg)(1)
> - chromium.linux.json: Linux Tests (dbg)(1)(32)
> - chromium.memory.fyi.json: Linux ChromeOS MSan Tests
> - chromium.memory.fyi.json: Linux MSan Tests
> - chromium.memory.fyi.json: Linux TSan Tests
> - chromium.win.json: XP Tests (1)
>
> Ran:
>   ./manage.py --convert ipc_mojo_unittests
>
> BUG=98637
>
> Committed: https://crrev.com/15593557f4f387d91dc7726511a20cb999c81561
> Cr-Commit-Position: refs/heads/master@{#337431}

TBR=viettrungluu@chromium.org,maruel@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637

Review URL: https://codereview.chromium.org/1218743008

Cr-Commit-Position: refs/heads/master@{#337473}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@tapted @JulienIsorce
Revert of cc: Measure compositor timing with finer granularity (patch…
2c6cf7d 
…set #8 id:140001 of https://codereview.chromium.org/1192663005/)

Reason for revert:
Flakily fails interactive_ui_tests on Linux Tests (dbg)(1)(32). Link:

https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/16214

failures:
AppWindowHiddenKeepAliveTest.ShownThenHiddenThenShown

Error:
[1:8:0706/185834:FATAL:compositor_timing_history.cc(104)] Check failed: base::TimeTicks() != begin_main_frame_sent_time_ (0 bogo-microseconds vs. 0 bogo-microseconds)
#0 0x0000ebbb49f4 base::debug::StackTrace::StackTrace()
#1 0x0000ebc17bee logging::LogMessage::~LogMessage()
#2 0x0000eec044b4 cc::CompositorTimingHistory::DidCommit()
#3 0x0000eec043ab cc::CompositorTimingHistory::BeginMainFrameAborted()
#4 0x0000eec0cfa5 cc::Scheduler::BeginMainFrameAborted()
#5 0x0000eed51290 cc::ThreadProxy::BeginMainFrameAbortedOnImplThread()
#6 0x0000eed60235 base::internal::RunnableAdapter\u003C>::Run()

See also:

https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)/builds/16214

Original issue's description:
> cc: Measure compositor timing with finer granularity
>
> Measures PrepareTiles, NotifyReadyToActivate, and
> Activation times separately such that idle times
> between actions don't polute results when the
> main thread is in a high latency mode or when
> actions are swap throttled.
>
> Also cleans up how we measure commit times and
> adds DCHECKs to make sure we don't ruin the ordering
> expectations of the CompositorTimingHistory class.
>
> Recording is only enabled while visible and we have
> an output surface in order to avoid cleanup logic
> skewing results.
>
> BUG=406158, 500744
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/65acb94f9258f985cbceedcd3b816cc55cc9522f
> Cr-Commit-Position: refs/heads/master@{#337539}

TBR=mithro@mithis.com,sunnyps@chromium.org,picksi@google.com,brianderson@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=406158, 500744

Review URL: https://codereview.chromium.org/1213653005

Cr-Commit-Position: refs/heads/master@{#337553}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@nico @JulienIsorce
Revert of Update mojo sdk to rev a05bfef8096006056b2fff78092faf14d131…
d91a60c 
…9782 (patchset #1 id:1 of https://codereview.chromium.org/1216023006/)

Reason for revert:
This caused

../../third_party/mojo/src/mojo/public/cpp/system/tests/macros_unittest.cc(133,1)
: error: 'selectany' can only be applied to data items with external linkage
MOJO_STATIC_CONST_MEMBER_DEFINITION
^
../../third_party/mojo/src\mojo/public/cpp/system/macros.h(65,56) :  note:
expanded from macro 'MOJO_STATIC_CONST_MEMBER_DEFINITION'
#define MOJO_STATIC_CONST_MEMBER_DEFINITION __declspec(selectany)
                                                       ^

on the clang/win bots. This is caused by
https://github.com/domokit/mojo/commit/6fb90aaf1c21dfefc526a0e589d54cb59511322d
which uses MOJO_STATIC_CONST_MEMBER_DEFINITION in an unnamed namespace,
and declspec(selectany) doesn't have any effect on internal symbols. Since it requires
a deps change to fix, reverting this roll for now. It should be easy to fix and reroll.

Original issue's description:
> Update mojo sdk to rev a05bfef8096006056b2fff78092faf14d1319782
>
> BUG=None
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/8de6daffb831795171ab2c9d4220d5bf63574833
> Cr-Commit-Position: refs/heads/master@{#337551}

TBR=jam@chromium.org,rockot@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/1219933003

Cr-Commit-Position: refs/heads/master@{#337601}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@JulienIsorce
Revert of mandoline filesystem: Save cookie data to the mojo:filesyst…
5986385 
…em. (patchset #16 id:300001 of https://codereview.chromium.org/1179413010/)

Reason for revert:
I'm seeing the following crash when closing the Mandoline window on Linux:

[0707/104753:FATAL:sqlite_persistent_cookie_store.cc(1135)] Check failed: false. Could not add a cookie to the DB.
#0 0x00000046aef1 __interceptor_backtrace
#1 0x7fec4b87954e base::debug::StackTrace::StackTrace()
#2 0x7fec4b479a1d logging::LogMessage::~LogMessage()
#3 0x7fec53f03c23 net::SQLitePersistentCookieStore::Backend::Commit()
#4 0x7fec53f04f38 net::SQLitePersistentCookieStore::Backend::InternalBackgroundClose()
#5 0x7fec53f1902b base::internal::RunnableAdapter<>::Run()

Reverting this patch resolves the issue.

Original issue's description:
> mandoline filesystem: Save cookie data to the mojo:filesystem.
>
> This makes the network service use the sql vfs to proxy writing the
> cookies to the filesystem service. This means mojo:network_service does
> not directly write its data to the OS filesystem, which will allow us to
> sandbox it.
>
> BUG=493311
>
> Committed: https://crrev.com/bbb9e2f6486cccadde4dc2fa077af8f694105eaa
> Cr-Commit-Position: refs/heads/master@{#337491}

TBR=jam@chromium.org,msw@chromium.org,sky@chromium.org,shess@chromium.org,erg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493311

Review URL: https://codereview.chromium.org/1225673006

Cr-Commit-Position: refs/heads/master@{#337602}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@JulienIsorce
Roll src/third_party/skia 07abbbe:5617900
d32a2b1 
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/07abbbe..5617900

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=stephana@google.com

Commits in this roll:
5617900 reed@chromium.org add SkImage::NewFromBitmap
6f29a3c scroggo@google.com Revert of Revert of Fixing libpng transform use  (patchset #1 id:1 of https://codereview.chromium.org/1213743004/)

Review URL: https://codereview.chromium.org/1214863014

Cr-Commit-Position: refs/heads/master@{#337603}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@mariakhomenko @JulienIsorce
Revert of Remove use of tab selector. (patchset #1 id:20001 of https:…
6d00f1a 
…//codereview.chromium.org/1229543002/)

Reason for revert:
Downstream test started breaking at this change with [FATAL:uma_session_stats.cc(57)] Check failed: active_session_count_ >= 0. Doing a speculative revert to see if it fixes the test.

Original issue's description:
> Remove use of tab selector.
>
> Seems like when activity onpause is called the mTabModelSelector is reset to null.
> It is possible that after that onPageLoadFinished event
> will fire which results in  use of mTabModelSelector in
> recordPageLoadStats and therefore will throw a
> NullPointerException.
>
> The guess is that removing the use of tab selector will fix the crashes.
>
> BUG=507452
>
> Committed: https://crrev.com/b8a6ad03629f475781d54baafe748aae6991852e
> Cr-Commit-Position: refs/heads/master@{#337666}

TBR=nyquist@chromium.org,asvitkine@chromium.org,gayane@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507452

Review URL: https://codereview.chromium.org/1225133002

Cr-Commit-Position: refs/heads/master@{#337929}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@Apeliotes @JulienIsorce
Revert of Re-enabling webrtc Telemetry tests. (patchset #1 id:1 of ht…
0a9d3c0 
…tps://codereview.chromium.org/1219923009/)

Reason for revert:
This is failing on the perf waterfall.

Please don't re-enable tests without review.

Original issue's description:
> Re-enabling webrtc Telemetry tests.
>
> BUG=501383
> TBR=simonhatch@chromium.org
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/641338ed1c8184afe343a5b378e7b232345290bd
> Cr-Commit-Position: refs/heads/master@{#337789}

TBR=simonhatch@chromium.org,phoglund@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501383

Review URL: https://codereview.chromium.org/1225123003

Cr-Commit-Position: refs/heads/master@{#337941}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@JulienIsorce
Revert of Roll src/third_party/skia 8ca93e7:c1d1dd7 (patchset #1 id:1…
2fefc09 
… of https://codereview.chromium.org/1227053003/)

Reason for revert:
Seeing failures in skia_unittests on Mac 10.10 tests bot shortly after this CL landed. Details in crbug.com/508342

Original issue's description:
> Roll src/third_party/skia 8ca93e7:c1d1dd7
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/8ca93e7..c1d1dd7
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=stephana@google.com
>
> Commits in this roll:
> c1d1dd7 scroggo@google.com Revert of Use the upstream version of libwebp, v0.4.3. (patchset #6 id:70001 of https://codereview.chromium.org/1178013008/)
> 5f0b0ad halcanary@google.com doc: add instructions to capture a `.skp` from chromium
> 8de8180 djsollen@google.com Add gradle wrappers for Android app builds
> 3aa0fb4 scroggo@chromium.org Use the upstream version of libwebp, v0.4.3.
> d07a279 bsalomon@google.com Revert of Rework GrPipelineInfo (patchset #7 id:120001 of https://codereview.chromium.org/1213383005/)
> 60c0475 mtklein@chromium.org Add tools/flatten to flatten nested pictures in .skps.
> b245605 joshualitt@chromium.org more threading of GrShaderDataManager
> 85ff25e joshualitt@chromium.org Thread GrShaderDataManager through Image filters
> 711a245 mtklein@chromium.org DM runs more than 100k tests now.
> eedc334 mtklein@chromium.org Fix leak in PictureTest.cpp
> 2cff176 joshualitt@chromium.org More threading of GrShaderDataManager
> f5179a4 bsalomon@google.com Makes GrPipelineInfo a class with query functions used by GrBatch subclasses.
> cc97ece bsalomon@google.com Add SK_API to GrSurface
> 3840846 mtklein@chromium.org DM: swizzle BGRA to RGBA before calculating pixel MD5.
>
> Committed: https://crrev.com/951ca805ed14fcfc1821b5bdb67478dde05b3f98
> Cr-Commit-Position: refs/heads/master@{#337885}

TBR=stephana@google.com,skia-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1228793002

Cr-Commit-Position: refs/heads/master@{#337978}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@saittam @JulienIsorce
Revert vector icon CLs.
e060267 
This reverts the following commits:

ac1592c73bdd24eca2ea3e591e8f7b199627e6e7: "mandoline: Fix aura build for android."
5490bafef2f11416bed41ad8017a6db500c67345: "Split vector icon commands into separate files aggregated at build time."
33b823af3e63287dbe850c253ae97593411d4f43: "Introduce some util code for drawing vector assets."

Reason for revert is 33b823af3e63287dbe850c253ae97593411d4f43, which
is one of the suspects for having broken browser_tests on Mac builders:

http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/8232
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/4313

Log output:

NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 (run #1):
[ RUN      ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0
[7393:1287:0708/150523:WARNING:vt_video_decode_accelerator.cc(206)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled.
[7390:45827:0708/150524:WARNING:data_reduction_proxy_config.cc(630)] SPDY proxy OFF at startup
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:645: Failure
Value of: [color redComponent]
  Actual: 0.952941
Expected: 0
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:646: Failure
Value of: [color greenComponent]
  Actual: 0.952941
Expected: 0
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:647: Failure
Value of: [color blueComponent]
  Actual: 0.952941
Expected: 1
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:654: Failure
Value of: [color redComponent]
  Actual: 0.952941
Expected: 1
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:655: Failure
Value of: [color greenComponent]
  Actual: 0.952941
Expected: 0
../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:656: Failure
Value of: [color blueComponent]
  Actual: 0.952941
Expected: 0
[  FAILED  ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0, where GetParam() = false (1817 ms)

BUG=508389
TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/1228923002 .

Cr-Commit-Position: refs/heads/master@{#338004}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@saittam @JulienIsorce
Revert of Re-enable ScreenOrientationBrowserTests on Chrome OS (patch…
60b6e5c 
…set #1 id:1 of https://codereview.chromium.org/1225093002/)

Reason for revert:
Unfortunately, the tests still flake a lot:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/17013/steps/content_browsertests/logs/ScreenOrientationBrowserTest.WindowOrientationChange
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/17014/steps/content_browsertests/logs/ScreenOrientationBrowserTest.ScreenOrientationChange

Original issue's description:
> Re-enable ScreenOrientationBrowserTests on Chrome OS
> Two tests were flaking on Chrome OS builds.
>
> Re-enabling to confirm that fixes to Screen Orientation API also fixed these tests.
>
> TEST=ScreenOrientationBrowserTest.ScreenOrientationChange,
> ScreenOrientationBrowserTest.WindowOrientationChange
> BUG=468259
>
> Committed: https://crrev.com/4fa07d46cbdea4b263ad07beca29f90b42757c67
> Cr-Commit-Position: refs/heads/master@{#337950}

TBR=mlamouri@chromium.org,jonross@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=468259

Review URL: https://codereview.chromium.org/1227163004

Cr-Commit-Position: refs/heads/master@{#338008}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@saittam @JulienIsorce
Revert of Revert vector icon CLs. (patchset #1 id:1 of https://codere…
02b2f15 
…view.chromium.org/1228923002/)

Reason for revert:
Reverting the revert - it turned out the failures weren't caused by the reverted CLs, but a bot configuration change happening at the same time: https://codereview.chromium.org/1212443005

Original issue's description:
> Revert vector icon CLs.
>
> This reverts the following commits:
>
> ac1592c73bdd24eca2ea3e591e8f7b199627e6e7: "mandoline: Fix aura build for android."
> 5490bafef2f11416bed41ad8017a6db500c67345: "Split vector icon commands into separate files aggregated at build time."
> 33b823af3e63287dbe850c253ae97593411d4f43: "Introduce some util code for drawing vector assets."
>
> Reason for revert is 33b823af3e63287dbe850c253ae97593411d4f43, which
> is one of the suspects for having broken browser_tests on Mac builders:
>
> http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/8232
> http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/4313
>
> Log output:
>
> NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0 (run #1):
> [ RUN      ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0
> [7393:1287:0708/150523:WARNING:vt_video_decode_accelerator.cc(206)] Failed to create hardware VideoToolbox session. Hardware accelerated video decoding will be disabled.
> [7390:45827:0708/150524:WARNING:data_reduction_proxy_config.cc(630)] SPDY proxy OFF at startup
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:645: Failure
> Value of: [color redComponent]
>   Actual: 0.952941
> Expected: 0
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:646: Failure
> Value of: [color greenComponent]
>   Actual: 0.952941
> Expected: 0
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:647: Failure
> Value of: [color blueComponent]
>   Actual: 0.952941
> Expected: 1
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:654: Failure
> Value of: [color redComponent]
>   Actual: 0.952941
> Expected: 1
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:655: Failure
> Value of: [color greenComponent]
>   Actual: 0.952941
> Expected: 0
> ../../chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm:656: Failure
> Value of: [color blueComponent]
>   Actual: 0.952941
> Expected: 0
> [  FAILED  ] NativeAppWindowCocoaBrowserTestInstance/NativeAppWindowCocoaBrowserTest.FrameColor/0, where GetParam() = false (1817 ms)
>
> BUG=508389
> TBR=estade@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/17399fb2b0a5fcba7c2dcb76ab2c597e6cf7c0db

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=508389

Review URL: https://codereview.chromium.org/1231843002 .

Cr-Commit-Position: refs/heads/master@{#338017}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@saittam @JulienIsorce
Revert of Change the mojo ProxyResolver to use ProxyResolverV8Tracing…
13b22cf 
…. (patchset #3 id:220001 of https://codereview.chromium.org/1166523003/)

Reason for revert:
This change introduced a use-after free that lit up the memory waterfall. Links to a couple of affected bots:

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/7754/steps/net_unittests/logs/stdio
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/2715/steps/net_unittests/logs/stdio
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%281%29/builds/42456/steps/memory%20test%3A%20net/logs/stdio
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%281%29/builds/1635/steps/memory%20test%3A%20net/logs/stdio

Report:

MojoProxyResolverV8TracingBindingsTest.Basic (run #1):
[ RUN      ] MojoProxyResolverV8TracingBindingsTest.Basic
==31178==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7fbd2d6e8eaf in NotifyEvent net/test/event_waiter.h:27:34
    #1 0x7fbd2d6e8eaf in net::MojoProxyResolverV8TracingBindingsTest::Alert(mojo::String const&) net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc:33:0
    #2 0x7fbd2d6e6ecb in AlertOnTaskRunner net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h:67:7
    #3 0x7fbd2d6e6ecb in net::MojoProxyResolverV8TracingBindings\u003Cnet::MojoProxyResolverV8TracingBindingsTest>::Alert(std::__1::basic_string\u003Cunsigned short, base::string16_char_traits, std::__1::allocator\u003Cunsigned short> > const&) net/proxy/mojo_proxy_resolver_v8_tracing_bindings.h:42:0
    #4 0x7fbd2d6e0c7e in SendAlertAndError net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc:45:5
    #5 0x7fbd2d6e0c7e in net::MojoProxyResolverV8TracingBindingsTest_Basic_Test::TestBody() net/proxy/mojo_proxy_resolver_v8_tracing_bindings_unittest.cc:62:0
    #6 0x7fbd308384d7 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2420:12
    #7 0x7fbd308384d7 in testing::Test::Run() testing/gtest/src/gtest.cc:2436:0
    #8 0x7fbd3083b965 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2612:5
    #9 0x7fbd3083d322 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #10 0x7fbd3085b73a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4604:11
    #11 0x7fbd3085a717 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #12 0x7fbd3085a717 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4222:0
    #13 0x7fbd323e8959 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #14 0x7fbd323e8959 in base::TestSuite::Run() base/test/test_suite.cc:229:0
    #15 0x7fbd323cded9 in Run base/callback.h:396:12
    #16 0x7fbd323cded9 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #17 0x7fbd323cd7a0 in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #18 0x7fbd2fab8304 in main net/test/run_all_unittests.cc:64:10
    #19 0x7fbd2745776c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0
    #20 0x7fbd2b7d61a8 in _start ??:0:0

  Uninitialized value was created by a heap allocation
    #0 0x7fbd2b82d402 in operator new(unsigned long) ??:0:0
    #1 0x7fbd2d6e64e5 in testing::internal::TestFactoryImpl\u003Cnet::MojoProxyResolverV8TracingBindingsTest_Basic_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486:39
    #2 0x7fbd3083b8ef in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2420:12
    #3 0x7fbd3083b8ef in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2603:0
    #4 0x7fbd3083d322 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2730:5
    #5 0x7fbd3085b73a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4604:11
    #6 0x7fbd3085a717 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2420:12
    #7 0x7fbd3085a717 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4222:0
    #8 0x7fbd323e8959 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2326:10
    #9 0x7fbd323e8959 in base::TestSuite::Run() base/test/test_suite.cc:229:0
    #10 0x7fbd323cded9 in Run base/callback.h:396:12
    #11 0x7fbd323cded9 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:184:0
    #12 0x7fbd323cd7a0 in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:423:10
    #13 0x7fbd2fab8304 in main net/test/run_all_unittests.cc:64:10
    #14 0x7fbd2745776c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/tmp/run_tha_testEIzO42/out/Release/net_unittests+0x2416eaf)
Exiting

Original issue's description:
> Change the mojo ProxyResolver to use ProxyResolverV8Tracing.
>
> This allows a much simpler implementation of GetLoadState and forwarding
> errors to a ProxyResolverErrorObserver as well as enabling a
> straightforward implementation of NetLog event reporting.
>
> BUG=467832
>
> Committed: https://crrev.com/9f5bf59b57e6b0662d9b9e0f6715ef7b5af092c0
> Cr-Commit-Position: refs/heads/master@{#337993}

TBR=eroman@chromium.org,amistry@chromium.org,sammc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467832

Review URL: https://codereview.chromium.org/1224083003 .

Cr-Commit-Position: refs/heads/master@{#338019}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@JulienIsorce
Revert of Also blacklist the use of eglWaitSyncKHR on Adreno 2xx GPUs…
2c10a1d 
…. (patchset #1 id:1 of https://codereview.chromium.org/1153263011/)

Reason for revert:
Version number was not incremented.

Original issue's description:
> Also blacklist the use of eglWaitSyncKHR on Adreno 2xx GPUs.
>
> BUG=482298
>
> Committed: https://crrev.com/d1326a816356a38f11fab266f4a62443f7940639
> Cr-Commit-Position: refs/heads/master@{#338009}

TBR=sievers@chromium.org,candrewsintegralblue@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=482298

Review URL: https://codereview.chromium.org/1229943002

Cr-Commit-Position: refs/heads/master@{#338057}
JulienIsorce pushed a commit that referenced this issue Jul 17, 2015
@mariakhomenko @JulienIsorce
Revert of Revert of Remove use of tab selector. (patchset #1 id:1 of h…
eae4538 
…ttps://codereview.chromium.org/1225133002/)

Reason for revert:
Revert did not fix the test problem, resubmitting.

Original issue's description:
> Revert of Remove use of tab selector. (patchset #1 id:20001 of https://codereview.chromium.org/1229543002/)
>
> Reason for revert:
> Downstream test started breaking at this change with [FATAL:uma_session_stats.cc(57)] Check failed: active_session_count_ >= 0. Doing a speculative revert to see if it fixes the test.
>
> Original issue's description:
> > Remove use of tab selector.
> >
> > Seems like when activity onpause is called the mTabModelSelector is reset to null.
> > It is possible that after that onPageLoadFinished event
> > will fire which results in  use of mTabModelSelector in
> > recordPageLoadStats and therefore will throw a
> > NullPointerException.
> >
> > The guess is that removing the use of tab selector will fix the crashes.
> >
> > BUG=507452
> >
> > Committed: https://crrev.com/b8a6ad03629f475781d54baafe748aae6991852e
> > Cr-Commit-Position: refs/heads/master@{#337666}
>
> TBR=nyquist@chromium.org,asvitkine@chromium.org,gayane@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=507452
>
> Committed: https://crrev.com/877dc3114a1a55c82859c9f56e8013a703fb7d8e
> Cr-Commit-Position: refs/heads/master@{#337929}

TBR=nyquist@chromium.org,asvitkine@chromium.org,gayane@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507452

Review URL: https://codereview.chromium.org/1229723006

Cr-Commit-Position: refs/heads/master@{#338078}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@simonhatch
Revert of Disable rasterize_and_record_micro.key_mobile_sites_smooth …
74ccc0b 
…on linux. (patchset #1 id:1 of https://codereview.chromium.org/1259113005/)

Reason for revert:
CL causing timeouts was reverted in https://codereview.chromium.org/1263923002/.

Original issue's description:
> Disable rasterize_and_record_micro.key_mobile_sites_smooth on linux.
>
> This is timing out (and taking 1h 40 mins to do so).
>
> BUG=515094
>
> Committed: https://crrev.com/4e2733b5808cf8e652540c74f2edbcf333f0523f
> Cr-Commit-Position: refs/heads/master@{#340918}

TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=515094

Review URL: https://codereview.chromium.org/1264873004

Cr-Commit-Position: refs/heads/master@{#341127}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@danakj
Revert of Enable surfaces on Android (try #5). (patchset #1 id:1 of h…
d922bf4 
…ttps://codereview.chromium.org/1262013002/)

Reason for revert:
Looks like this is causing webgl conformance test failures. ~21 failures each run since this landed.

Example: http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/1430/steps/webgl_conformance_tests/logs/stdio#failure7

More: http://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29

Original issue's description:
> Enable surfaces on Android (try #5).
>
> The browser compositor contents and renderer contents are each put into separate
> layers which are aggregated together by a Display.
>
> BUG=449319
>
> Committed: https://crrev.com/134fccf1b3d33f7dd28cd8c0c498bb059fc50ea9
> Cr-Commit-Position: refs/heads/master@{#340953}

TBR=sievers@chromium.org,jbauman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449319

Review URL: https://codereview.chromium.org/1254423005

Cr-Commit-Position: refs/heads/master@{#341163}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
Revert of Ensure that title and state updating works without page id.…
e61aa95 
… (patchset #1 id:1 of https://codereview.chromium.org/1259213003/)

Reason for revert:
Title updating isn't working; revert for now.

Original issue's description:
> Ensure that title and state updating works without page id.
>
> BUG=369661
> TEST=everything stays green
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/4a1c1980e95fe8cd36f7b2910757ace3b8970aa0
> Cr-Commit-Position: refs/heads/master@{#340960}

TBR=nasko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661

Review URL: https://codereview.chromium.org/1254423007

Cr-Commit-Position: refs/heads/master@{#341188}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
Reland of [Chromecast] Change chromecast_branding to public (patchset #1
c9612c2 
 id:1 of https://codereview.chromium.org/1266723002/)

Reason for revert:
retrieve the branding change CL since internal CL is submitted.

Original issue's description:
> Revert of [Chromecast] Change chromecast_branding to public (patchset #6 id:100001 of https://codereview.chromium.org/1262673004/)
>
> Reason for revert:
> Revert the CL temporary for TOT build. Checked in again once the internal CLs are approved.
>
> Original issue's description:
> > [Chromecast] Change chromecast_branding to public
> >
> > Change chromecast_branding from Chrome/Chromium to
> > public/internal/google in gyp file. "public" is the same as "Chromium"
> > and the other two are considered as "Chrome".
> >
> > BUG=
> >
> > Committed: https://crrev.com/0f46bd94566380a99ecda0753f659b7e114e3d3d
> > Cr-Commit-Position: refs/heads/master@{#341016}
>
> TBR=lcwu@chromium.org,gunsch@chromium.org,byungchul@chromium.org,slan@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/cc83429750aac56eef9068fcd617d4474d310960
> Cr-Commit-Position: refs/heads/master@{#341034}

TBR=lcwu@chromium.org,gunsch@chromium.org,byungchul@chromium.org,slan@chromium.org,gunsch@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1256323009

Cr-Commit-Position: refs/heads/master@{#341191}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@erikchen
Reland #1: "Migrate pregenerated profiles before using them."
6686606 
The first attempt to land the CL failed due to boto credential problems. Trying
again.

> This prevents migrations from affecting the measured startup time when a new
> version of Chrome is run against an old profile.

BUG=442546, 513086
TBR=nednguyen@google.com

Review URL: https://codereview.chromium.org/1263063002

Cr-Commit-Position: refs/heads/master@{#341199}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@erikchen
Reland #1: Clean up interface of attachment broker.
6e996a9 
I forgot to initialize a member variable, which is why the original CL flakily
succeeded (and managed to pass the CQ).

Original issue's description:
> ipc: Clean up interface of attachment broker.
>
> AttachmentBrokerUnprivileged now has a method
> DesignateBrokerCommunicationChannel which is used by non-broker processes to
> designate an IPC::Channel as the communication medium for brokerable attachment
> messages. IPC::Channel has a new member attachment_broker_endpoint_ which causes
> it to pass all messages through the attachment broker before forwarding them to
> the listener.
>
> BUG=493414
>
> Committed: https://crrev.com/9a06836982214f2edced21bbd1615b49e7f231bf
> Cr-Commit-Position: refs/heads/master@{#341143}

BUG=493414
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/1258323004

Cr-Commit-Position: refs/heads/master@{#341207}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@erikchen
Reland #1: Switch the default build configuration to use the 10.10 SDK.
efe6a82 
All known problems have been fixed since the first attempt to land this CL.

Original issue's description:
> mac: Switch the default build configuration to use the 10.10 SDK.
>
> This change is intended to be temporary. The goal is to release a Canary
> compiled against the 10.10 SDK, and then to revert this CL.
>
> BUG=463170
>
> Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> Cr-Commit-Position: refs/heads/master@{#340992}

TBR=thakis@chromium.org,amineer@chromium.org
BUG=463170

Review URL: https://codereview.chromium.org/1257643005

Cr-Commit-Position: refs/heads/master@{#341261}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@dmurph
Revert of Reland #1: Switch the default build configuration to use th…
22ce0a6 
…e 10.10 SDK. (patchset #1 id:1 of https://codereview.chromium.org/1257643005/)

Reason for revert:
I believe this is causing a lot of issues with layout, no idea why though.
https://code.google.com/p/chromium/issues/detail?id=515836

Original issue's description:
> Reland #1: Switch the default build configuration to use the 10.10 SDK.
>
> All known problems have been fixed since the first attempt to land this CL.
>
> Original issue's description:
> > mac: Switch the default build configuration to use the 10.10 SDK.
> >
> > This change is intended to be temporary. The goal is to release a Canary
> > compiled against the 10.10 SDK, and then to revert this CL.
> >
> > BUG=463170
> >
> > Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> > Cr-Commit-Position: refs/heads/master@{#340992}
>
> TBR=thakis@chromium.org,amineer@chromium.org
> BUG=463170
>
> Committed: https://crrev.com/345c0cf47947f209e628941b38d76dca90aee49d
> Cr-Commit-Position: refs/heads/master@{#341261}

TBR=amineer@chromium.org,thakis@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463170

Review URL: https://codereview.chromium.org/1266603007

Cr-Commit-Position: refs/heads/master@{#341306}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@johnmellor
Revert of 'firstPartyForCookies' walks the ancestor tree. (patchset #1 …
046cf0a 
…id:1 of https://codereview.chromium.org/1253923002/)

Reason for revert:
This causes http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html to consistently fail on all platforms:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fsecurity%2FXFrameOptions%2Fx-frame-options-deny-meta-tag-parent-same-origin-deny.html&testType=layout-tests

Original issue's description:
> 'firstPartyForCookies' walks the ancestor tree.
>
> Calling 'firstPartyForCookies' on the top level frame's document will
> give a very different result then calling it on a subframe's document.
>
> R=nasko@chromium.org
>
> Committed: https://crrev.com/e91e43556ecdbf519667f55b729289fcaef9b3af
> Cr-Commit-Position: refs/heads/master@{#341304}

TBR=nasko@chromium.org,mkwst@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1254893004

Cr-Commit-Position: refs/heads/master@{#341310}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@miu-chromium
Revert of [Cast] Add back ignored width/height in RtpPayloadParams ID…
ebc74fe 
…L for Chrome 43. (patchset #1 id:1 of https://codereview.chromium.org/1009643002/)

Reason for revert:
As discussed in bug 466357, the plan was to revert this patchset for Chrome 44 and later.  These fields will be gone starting in Chrome 46, assuming this lands within the next couple weeks.

Original issue's description:
> [Cast] Add back ignored width/height in RtpPayloadParams IDL for Chrome 43.
>
> A recent change (https://codereview.chromium.org/973753002/) removed the
> width/height properties from the IDL, but the Google Cast Extension needs
> them to be present until a patch rolls out to all Chrome Canary/Dev/Beta
> users.
>
> BUG=466357
> TBR=finnur@chromium.org
>
> Committed: https://crrev.com/5ba8aa856919269a1a079c376d70480da0c2fc23
> Cr-Commit-Position: refs/heads/master@{#320634}

TBR=finnur@chromium.org
BUG=466357

Review URL: https://codereview.chromium.org/1267073004

Cr-Commit-Position: refs/heads/master@{#341474}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@jeisinger
Revert of Roll src/tools/swarming_client/ to 2866a22530cb65feae5d9f64…
0290d47 
…c83636aed5391d06. (patchset #1 id:1 of https://codereview.chromium.org/1261993010/)

Reason for revert:
speculative revert to see whether this fixes Android tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/29341/steps/Instrumentation%20test%20ChromePublicTest/logs/stdio

Original issue's description:
> Roll src/tools/swarming_client/ to 2866a22530cb65feae5d9f64c83636aed5391d06.
>
> $ git log b39a448d8..2866a2253 --date=short --format='%ad %ae %s'
> 2015-07-31 vadimsh Do retries in file_path.rmtree on Linux too.
> 2015-07-31 vadimsh Do not recreate the tree in isolate cache directory.
> 2015-07-31 vadimsh Fix auth.py.
> 2015-07-15 maruel Migrate and merge logging_utils from swarming_bot into client/utils.
> 2015-06-11 vadimsh Make --auth-service-account-json override "is_headless()".
>
> R=nodir@chromium.org
> BUG=515914
>
> Committed: https://crrev.com/8118f931536af287db26bdd107f63a3f8686ce44
> Cr-Commit-Position: refs/heads/master@{#341444}

TBR=nodir@chromium.org,vadimsh@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=515914

Review URL: https://codereview.chromium.org/1267923003

Cr-Commit-Position: refs/heads/master@{#341495}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@johnmellor
Revert of Skip the Service Worker CORS fallback for same origin reque…
ee18ed2 
…sts. [2/2 chromium] (patchset #1 id:40001 of https://codereview.chromium.org/1242953007/)

Reason for revert:
This broke http/tests/serviceworker/fetch-request-fallback.html, causing failures on 3 bots and timeouts on 18 bots.

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fserviceworker%2Ffetch-request-fallback.html&testType=layout-tests

Original issue's description:
> Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium]
>
> We are sending CORS fallback response from the browser process to the page's renderer process, when the ServiceWorker doesn't handle the CORS fetch request.
> But when the request URL's origin is same as the page's security origin, we can skip the fallback and send the request from the browser process.
>
> This change will improve the delay of the CORS fallback for same origin requests, especially when the renderer main thread is busy.
>
> 1/2 blink: https://codereview.chromium.org/1243353002/
> 2/2 chromium: this cl.
>
> BUG=512764
>
> Committed: https://crrev.com/97b13409b0c601f21f048744fa8e31852b476337
> Cr-Commit-Position: refs/heads/master@{#341482}

TBR=falken@chromium.org,tyoshino@chromium.org,horo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512764

Review URL: https://codereview.chromium.org/1258893004

Cr-Commit-Position: refs/heads/master@{#341499}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@Steelskin
Revert of Pull DocumentTabModel restoration logic into StorageDelegat…
bcfb1c0 
…e (patchset #1 id:1 of https://codereview.chromium.org/1265833006/)

Reason for revert:
This broke DocumentTabModelImplTest.testMissingTaskAddedAndUnretargetable on Lollipop.
Uncaught because we do not have Lollipop testers on the Chromium waterfall.

Original issue's description:
> Pull DocumentTabModel restoration logic into StorageDelegate
>
> Need this logic pulled out so that it can be used when migrating
> to a TabManager.  Mimics how TabModelImpl uses the TabPersistentStore,
> since the StorageDelegate and the TabPersistentStore are both
> TabPersister subclasses.
>
> The logic is slightly different between since it was a little
> more complicated than it had to be.
>
> BUG=443772
>
> Committed: https://crrev.com/8d8bf13aa89cf04498ac65b88bbd76fe09b0ac38
> Cr-Commit-Position: refs/heads/master@{#341417}

TBR=mariakhomenko@chromium.org,dfalcantara@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=443772

Review URL: https://codereview.chromium.org/1271753002

Cr-Commit-Position: refs/heads/master@{#341514}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
Roll src/third_party/skia 76bb228:d8ea6b4
70ab5ec 
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/76bb228..d8ea6b4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Commits in this roll:
d8ea6b4 djsollen@google.com fix tests for android framework build
d45fb5a joshualitt@chromium.org Add BW masks to random scaler context
2a6f747 joshualitt@google.com Revert of Add BW masks to random scaler context (patchset #1 id:1 of https://codereview.chromium.org/1270793003/)
a4a5306 joshualitt@chromium.org Add BW masks to random scaler context
44c4851 joshualitt@chromium.org adding gm to use random scaler context
c2e6827 reed@google.com remove now-dead flags

Review URL: https://codereview.chromium.org/1264253003

Cr-Commit-Position: refs/heads/master@{#341527}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@rsolomakhin
Revert of Add the 'Ask Google' option to the spelling submenu on Mac.…
f03c182 
… (patchset #1 id:1 of https://codereview.chromium.org/1213133004/)

Reason for revert:
Reverting after discussion with Rachel.

Original issue's description:
> Add the 'Ask Google' option to the spelling submenu on Mac.
>
> For some reason the "Ask Google" option does not appear in the right-
> click menu on Mac, even though it's present in the Settings menu.
>
> BUG=5102
>
> Committed: https://crrev.com/8657b1d9e7c2040de20632fdf2ede3765cec4d9c
> Cr-Commit-Position: refs/heads/master@{#336790}

TBR=lazyboy@chromium.org,juliusa@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=5102

Review URL: https://codereview.chromium.org/1264583003

Cr-Commit-Position: refs/heads/master@{#341594}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@Apeliotes
Reland of Create classes_util API, change discover to return a list i…
1d90eba 
…nstead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1263063003/)

Reason for revert:
The telemetry tests aren't broken. The perf_unittests are because they don't pick tests in a deterministic way. Reverting after a change to make them deterministic.

Original issue's description:
> Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/)
>
> Reason for revert:
> This appears to break the XP telemetry tests. Details on the bug.
>
> Original issue's description:
> > Create classes_util API, change discover to return a list instead of a dict.
> >
> > BUG=498968
> > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
> >
> > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0
> > Cr-Commit-Position: refs/heads/master@{#341129}
>
> TBR=dtu@chromium.org,bengr@chromium.org,aiolos@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=498968
>
> Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb
> Cr-Commit-Position: refs/heads/master@{#341218}

TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org
BUG=498968

Review URL: https://codereview.chromium.org/1262623007

Cr-Commit-Position: refs/heads/master@{#341603}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
Revert of Yield in DoReadLoop after 20 ms instead of 50 ms. (patchset #1
df20c1c 
 id:1 of https://codereview.chromium.org/1266903005/)

Reason for revert:
Reverting because of test failures at http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/35609.

Original issue's description:
> Yield in DoReadLoop after 20 ms instead of 50 ms.
>
> Decrease the time threshold in SpdySession::DoReadLoop from 50 ms to 20 ms.  See
> bug for a discussion on the value.
>
> BUG=462774
>
> Committed: https://crrev.com/68b3f5152c0d74f87a068961c1a8f26c36b9b7c3
> Cr-Commit-Position: refs/heads/master@{#341519}

TBR=rch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462774

Review URL: https://codereview.chromium.org/1269003007

Cr-Commit-Position: refs/heads/master@{#341611}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@Apeliotes
Revert of Create classes_util API, change discover to return a list i…
1b1ea80 
…nstead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1262623007/)

Reason for revert:
Landed even though the patch failed.

Original issue's description:
> Reland of Create classes_util API, change discover to return a list instead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1263063003/)
>
> Reason for revert:
> The telemetry tests aren't broken. The perf_unittests are because they don't pick tests in a deterministic way. Reverting after a change to make them deterministic.
>
> Original issue's description:
> > Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/)
> >
> > Reason for revert:
> > This appears to break the XP telemetry tests. Details on the bug.
> >
> > Original issue's description:
> > > Create classes_util API, change discover to return a list instead of a dict.
> > >
> > > BUG=498968
> > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
> > >
> > > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0
> > > Cr-Commit-Position: refs/heads/master@{#341129}
> >
> > TBR=dtu@chromium.org,bengr@chromium.org,aiolos@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=498968
> >
> > Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb
> > Cr-Commit-Position: refs/heads/master@{#341218}
>
> TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org
> BUG=498968
>
> Committed: https://crrev.com/2c1531af216c026be0b4aed672dc89d264f95a72
> Cr-Commit-Position: refs/heads/master@{#341603}

TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498968

Review URL: https://codereview.chromium.org/1272433002

Cr-Commit-Position: refs/heads/master@{#341621}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@Apeliotes
Reland of Create classes_util API, change discover to return a list i…
975a4da 
…nstead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1263063003/)

Reason for revert:
The telemetry tests aren't broken. The perf_unittests are because they don't pick tests in a deterministic way. Reverting after a change to make them deterministic.

Original issue's description:
> Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/)
>
> Reason for revert:
> This appears to break the XP telemetry tests. Details on the bug.
>
> Original issue's description:
> > Create classes_util API, change discover to return a list instead of a dict.
> >
> > BUG=498968
> > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
> >
> > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0
> > Cr-Commit-Position: refs/heads/master@{#341129}
>
> TBR=dtu@chromium.org,bengr@chromium.org,aiolos@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=498968
>
> Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb
> Cr-Commit-Position: refs/heads/master@{#341218}

TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org
BUG=498968

CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1262623007

Cr-Commit-Position: refs/heads/master@{#341646}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@jeisinger
Revert of Create classes_util API, change discover to return a list i…
894e4be 
…nstead of a dict. (patchset #2 id:280001 of https://codereview.chromium.org/1262623007/ )

Reason for revert:
fails reliably on XP tests: https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20(1)/builds/39209/steps/telemetry_perf_unittests/logs/stdio

Original issue's description:
> Reland of Create classes_util API, change discover to return a list instead of a dict. (patchset #1 id:1 of https://codereview.chromium.org/1263063003/)
>
> Reason for revert:
> The telemetry tests aren't broken. The perf_unittests are because they don't pick tests in a deterministic way. Reverting after a change to make them deterministic.
>
> Original issue's description:
> > Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/)
> >
> > Reason for revert:
> > This appears to break the XP telemetry tests. Details on the bug.
> >
> > Original issue's description:
> > > Create classes_util API, change discover to return a list instead of a dict.
> > >
> > > BUG=498968
> > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
> > >
> > > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0
> > > Cr-Commit-Position: refs/heads/master@{#341129}
> >
> > TBR=dtu@chromium.org,bengr@chromium.org,aiolos@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=498968
> >
> > Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb
> > Cr-Commit-Position: refs/heads/master@{#341218}
>
> TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org
> BUG=498968
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/7e6fefcf3b839256c97e2e7bc0bfc3c53af75c8d
> Cr-Commit-Position: refs/heads/master@{#341646}

TBR=dtu@chromium.org,bengr@chromium.org,avi@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498968

Review URL: https://codereview.chromium.org/1267243002

Cr-Commit-Position: refs/heads/master@{#341692}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@zhenyao
Revert of Roll src/third_party/skia 4b3050b:846b022 (patchset #1 id:1…
948158f 
… of https://codereview.chromium.org/1261943003/ )

Reason for revert:
See crbug.com/516860

Please fix the uninitialized access issue before next roll.  Thank you.

Original issue's description:
> Roll src/third_party/skia 4b3050b:846b022
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/4b3050b..846b022
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=mtklein@google.com
>
> Commits in this roll:
> 846b022 joshualitt@chromium.org Break LCD and Bitmap text dependency on hardcoded atlas values
> 1c005e4 scroggo@chromium.org Create a scanline decoder without creating a codec
> ddc726f joshualitt@chromium.org Add cheat sheet to wrangler doc
> dce5ce4 mtklein@chromium.org Port SkBlurImage opts to SkOpts.
> 562a66b mtklein@chromium.org Revert "Implement caching of filled paths in the tessellated path renderer." This reverts commit 468dfa72eb6694145487be17876804dfca3b7adb.
> dea6e1c reed@google.com update image bench to test gpu and cpu images against raster surface
> 6f1216a reed@google.com cache private readback for gpu-images
> fae0102 robertphillips@google.com Remove IGNORE_ROT_AA_RECT_OPT flag
>
> Committed: https://crrev.com/406a98d80d074521bb2848a9a023e71a9e155848
> Cr-Commit-Position: refs/heads/master@{#341789}

TBR=mtklein@google.com,mtklein@chromium.org,skia-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1256773004

Cr-Commit-Position: refs/heads/master@{#341818}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
Roll src/third_party/skia 1cd6311:b2aa7cb
6b27009 
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1cd6311..b2aa7cb

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=mtklein@google.com

Commits in this roll:
b2aa7cb joshualitt@chromium.org This CL wires up the backend portion necessary for sending transformed coords via vertex attributes.
0e8296e bsalomon@google.com Move impl of stroke rect batch from h to cpp
ee14a62 bsalomon@google.com Give strokerectbatch a proper home
8470290 joshualitt@chromium.org fix for GrFragmentProcessor isEqual in GrPipeline
d8aa59d robertphillips@google.com Remove SHADER_AA_FILL_RECT flag
6c17ca5 mtklein@chromium.org Update yasm .gyp for tweaked ASAN bots.
c0e1af1 mtklein@chromium.org Revert of Intentionally crash DM to make sure all bots are up-to-date. (patchset #1 id:1 of https://codereview.chromium.org/1274693002/ )
fa1c073 borenet@google.com Fix make.py: BUILDTYPE
3749b96 mtklein@chromium.org Intentionally crash DM to make sure all bots are up-to-date.
dd958e7 mtklein@google.com Add tools/ubsan.supp.

Review URL: https://codereview.chromium.org/1279473002

Cr-Commit-Position: refs/heads/master@{#341945}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@tkent-google
Revert of Disable ExternalPopupMenuRemoveTest.RemoveOnChange. (patchset
1432227 
#1 id:1 of https://codereview.chromium.org/1271223002/ )

Reason for revert:
Reverted Blink r200000.

Original issue's description:
> Disable ExternalPopupMenuRemoveTest.RemoveOnChange.
>
> The behavior was intentionally changed by Blink r200000 [1].
>
> [1] https://src.chromium.org/viewvc/blink?revision=200000&view=revision
>
> BUG=516945
> TBR=keishi@chromium.org,avi@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/372de78e05c538ae724563ee107e47fbd17498d4
> Cr-Commit-Position: refs/heads/master@{#341867}

TBR=keishi@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516945

Review URL: https://codereview.chromium.org/1274813005

Cr-Commit-Position: refs/heads/master@{#341991}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
Revert of Fix gn check error (patchset #1 id:1 of https://codereview.…
4086feb 
…chromium.org/1279553002/ )

Reason for revert:
My original patch https://codereview.chromium.org/1262173005/ , broke MediaRouterMojoImplTest.QueuedWhileAsleep on linux debug. I'm reverting this as this builds on the other patch.

Original issue's description:
> Fix gn check error
>
> Android BUILD.gn files needed to be updated because of moving of files.
>
> BUG=none
> TEST=none
> R=jam@chromium.org
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/c9cc182781484f9010f062859cda048afefe5425
> Cr-Commit-Position: refs/heads/master@{#341992}

TBR=jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1278653002

Cr-Commit-Position: refs/heads/master@{#342013}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
Revert of Roll WebRTC 9677:9681, Libjingle 9679:9681 (patchset #1 id:…
6c767ae 
…1 of https://codereview.chromium.org/1275823002/ )

Reason for revert:
This broke the build, more details follow later.

Original issue's description:
> Roll WebRTC 9677:9681, Libjingle 9679:9681
>
> WebRTC 9677:9681
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/61ee070..6f6a712
>
> Libjingle 9679:9681
>
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/4a1fae7..8a095f2
>
> TBR=
> BUG=
>
> Committed: https://crrev.com/c0ff177f4b4076ec08d4631e1eab35ae8a2a1cb4
> Cr-Commit-Position: refs/heads/master@{#342071}

TBR=tommi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1275843002

Cr-Commit-Position: refs/heads/master@{#342072}
aobzhirov pushed a commit that referenced this issue Aug 7, 2015
@hiroshige-g
Revert of Re-enable ChannelMojo (patchset #1 id:20001 of https://code…
c16490e 
…review.chromium.org/1262503011/ )

Reason for revert:
Suspecting this CL causes many Layout test failures (https://crbug.com/517391).

Original issue's description:
> Re-enable ChannelMojo
>
> The performance regression seen previously was probably
> misattributed to ChannelMojo. Also, given that a great deal of
> code will now take advantage of the channel's thread-safe Send,
> this is expected to result in an net performance improvement.
>
> BUG=500019
> TBR=jam@chromium.org
>
> Committed: https://crrev.com/ab1a53c964a77dabb6d08b7199111b51a330885e
> Cr-Commit-Position: refs/heads/master@{#342055}

TBR=rockot@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=500019

Review URL: https://codereview.chromium.org/1265383006

Cr-Commit-Position: refs/heads/master@{#342085}
@JulienIsorce JulienIsorce changed the title Build GStreamer locally in chromium build for developement purposes Support building and running Chromium GStreamer backend within gst-uninstalled environment Oct 23, 2015
@JulienIsorce
Copy link
Contributor Author

Fixed https://bugzilla.gnome.org/show_bug.cgi?id=720778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JulienIsorce