[onert] Let's remove default value from onert_train/args

[zetwhite]

Background

Motivation1

For now, onert_train can set training info in 2 ways.

• using model file (by circle file metadata)
• using onert_train command line input

Since command line input always has a default value, onert_train always choose to use the cmd line info instead of choosing the model file's.

So, Let's

• remove the default value(info)
• make it choose to use the model file training info, if training info is not given from cmd line.

Motivation2

While working on motivation1, I found out that

• onert_train/args just save an integer value
• onert_train main does parsing - from an integer value to the corresponding enum NNFW_TRAIN_*.

Since onert_train/args holds an integer value, It is hard to remove the default value. More exactly, it is hard to represent that 'nothing is given'.

Additionally parsing (integer to NNfW_TRAIN enum) is not a kind of training logic, IMO it is better to remove it from the main.

---

Suggestion

In such background, I suggest this direction: #12445

AS-IS

• onert_train/args: hold an integer value
• onert_train/onert_train: parse integer value to NNFW_TRAIN_* enum and always overwrite session's training info.

TO-BE

• onert_train/args : directly hold an enum NNFW_TRAIN_* and to represent nothing is given use std::optional.
• onert_train/args : check cmd line parameter is given or not, and then decide whether to overwrite the session's training info or not.

Side effects of my suggestion

To merge the draft, it expects some additional changes :

• Since std::optional is introduced in C++17, C++17 needs to be used to compile onert_train.
• Since Boost v1.58.0 used in android-build does not support C++17, boost version has to be upgraded.
  • Boost supports C++17 after v1.65.0, But the latest Boost supports various compilers including both Clang and GCC.
  • So I'd lie to upgrade to v1.84.0 which is the latest.
  • Draft: Remove default value from onert_train  #12445 (comment)

[zetwhite]

@Samsung/one_onert

Could you briefly check draft #12445 and leave any opinion about the change?
I'd like to ask if it is fine to use C++17 for onert_train and upgrade the boost version to the latest.

[jyoungyun]

I'd like to ask if it is fine to use C++17 for onert_train and upgrade the boost version to the latest.

👍

[zetwhite]

I asked @Samsung/one_onert opinion through another channel.

There are some opinions like :

• It is okay to use C++17 in onert/tools.
  • (note) Since runtime/onert, runtime/lib is related with tizen release, it can NOT use C++17. (Tizen doesn't support C++17 officially. )
• boost version upgrading have to be careful.
  • Because ONE-frontend has been used boost(not now)
  • There might be other libraries that depends on boost version.

---

Conclusion :

#12525 (upgrading boost version) merged and it looks fine.

So, There is no big problem to proceeding the draft i suggested #12445.
I'll make PRs based on #12445 .

[zetwhite]

TODO

• refactor onert_train/src/nnfw_utils - [tools/onert_train] Refactor print logic of train info #12528
• update onert_train to use C++17 - [tools/onert_train] Update onert_train to use C++17 #12529
• update onert_train/args.h to use NNFW_TRAIN_* enum
  • add to_underlying - [onert/libs] Add to_underlying to misc #12556
  • update args hold NNFW_TRAIN_* - [tools/onert_train] Revise args to hold NNFW_TRAIN_* enum #12545
• remove default argument from args.h [tools/onert_train] Remove default value from onert_train/args #12600

[YongseopKim]

What happened this issue? 😆

[jyoungyun]

@YongseopKim

What happened this issue? 😆

@zetwhite linked each PR to this issue using a comment like this in the process to resolve: https://github.com/Samsung/ONE/issues/12520. It linked each PR to this issue, and if the PR was successfully merged, it would close this issue because it was linked to the PR. That's the why this issue was closed repeatedly. 😄

[zetwhite]

Now, onert_train runs with below policy:

• onert_train expects that circle+ file is given - model file with training information.
• If a user wants to train by setting training information manually, the User can update training information by cmd line option.
• If a user wants to train using circle file (not circle+), the User can train it by manually setting training information by using cmd line option.

Case	Model file info is given	cmd line info is given	onert_train Selected
1	X	X	train info is undefined, throw error
2	O (circle+)	X	model file info selected
3	O (circle+)	O	cmd line info is selected
4	X (circle, not circle+)	O	cmd line info is selected