Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.3 Release #181

Merged
merged 5 commits into from
May 8, 2023
Merged

5.3 Release #181

merged 5 commits into from
May 8, 2023

Conversation

secureideas
Copy link
Member

This is the pull request to make SamuraiWTF 5.3 the release. We will need to tag the files after accepting the PR.

@secureideas secureideas requested a review from JGillam May 8, 2023 00:47
mgillam
mgillam previously approved these changes May 8, 2023
Copy link
Member

@mgillam mgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question where amazon-linux/Vagrantfile has a different version (6.0) from the rest (5.3). Otherwise all looks fine.

@@ -63,7 +63,7 @@ Vagrant.configure("2") do |config|
samuraiwtf.vm.provider "virtualbox" do |vb|
# Display the VirtualBox GUI when booting the machine
vb.gui = true
vb.name = "SamuraiWTF-5.2"
vb.name = "SamuraiWTF-6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this wouldn't be the same version as the Vagrantfile at the root?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 5.3 I think

Copy link
Member

@JGillam JGillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the one place we say 6.0 instead of 5.3 needs to be made consistent with the other changes before this is merged.

@secureideas secureideas merged commit c4ddda6 into main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants