Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target FPS has several types and produces warnings #144

Closed
Maykeye opened this issue Jan 26, 2020 · 1 comment
Closed

Target FPS has several types and produces warnings #144

Maykeye opened this issue Jan 26, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Maykeye
Copy link

Maykeye commented Jan 26, 2020

Describe the bug
When compiling with a compiler which frowns between float<->uint32_t implicit conversions, code produces warnings because target fps is float in some places, integer in other:

To Reproduce

  1. Compile in VS2017 c++ file with `#include <flecs.h>
  2. get >e:\work\vs2017.libs\flecs\include\flecs\flecs.hpp(361): warning C4244: 'argument': conversion from 'uint32_t' to 'float', possible loss of data

Expected behavior
Same types everywhere with no warnings

Additional context
Related to #70 (compiler warnings with Visual Studio 2017), but if #70 it's one time problem - you compile the library and forget about it as you use compiled lib, here warnings produced every time you include the header in actual projects.

@Maykeye Maykeye added the bug Something isn't working label Jan 26, 2020
@SanderMertens
Copy link
Owner

Thanks for reporting! I'll change the type to float everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants