-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler warnings with Visual Studio 2017 #70
Labels
Comments
SanderMertens
added a commit
that referenced
this issue
Sep 9, 2019
@mattiasljungstrom Sure thing! I just built Flecs with pedantic warnings on MacOS and fixed a few warnings that showed up there, but it seems like msvc is catching more. If you can do a PR I'll definitely merge it. |
rishubn
added a commit
to rishubn/flecs
that referenced
this issue
Nov 8, 2019
rishubn
added a commit
to rishubn/flecs
that referenced
this issue
Nov 9, 2019
rishubn
added a commit
to rishubn/flecs
that referenced
this issue
Nov 10, 2019
rishubn
added a commit
to rishubn/flecs
that referenced
this issue
Nov 10, 2019
rishubn
added a commit
to rishubn/flecs
that referenced
this issue
Nov 13, 2019
I've recently fixed a lot of warnings in MSVC related to type conversions and "unsafe" functions, so closing this issue. If you are still seeing issues with MSVC, feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've been evaluating this library as one possible solution for a project, but I noticed there are quite a lot of warnings when compiling with visual studio 2017.
Examples:
flecs\src\column_system.c(281): warning C4146: unary minus operator applied to unsigned type, result still unsigned
flecs\src\column_system.c(934): warning C4244: '=': conversion from 'uint64_t' to 'uint32_t', possible loss of data
flecs\src\column_system.c(1001): warning C4244: '+=': conversion from 'double' to 'float', possible loss of data
flecs\src\entity.c(1050): warning C4018: '<': signed/unsigned mismatch
flecs\src\entity.c(300): warning C4090: 'function': different 'const' qualifiers
flecs\src\type.c(1068): warning C4244: 'initializing': conversion from 'ecs_entity_t' to 'int', possible loss of data
etc...
Would you be interested in a push request if I keep using this library?
The text was updated successfully, but these errors were encountered: