Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packets with unread bytes should be handled #17

Closed
gioiann opened this issue Sep 10, 2019 · 2 comments
Closed

Packets with unread bytes should be handled #17

gioiann opened this issue Sep 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@gioiann
Copy link

gioiann commented Sep 10, 2019

On LBSG servers the ResourcePacksInfo is encoded like that

Causing this error which won't allow the packet to be handled:

1 unread bytes left in packet *packet.ResourcePacksInfo{TexturePackRequired:false HasScripts:false BehaviourPacks:[] TexturePacks:[]}: 0x00 (full payload: 0x0600000000000000)

The client instead doesn't care about unread bytes and works just fine.

I think gophertunnel should behave as close to the Minecraft client as possible so, in case there are unread bytes an error should be printed but the packet should still be handled

To reproduce the error simply join play.lbsg.net:19132 with the proxy

@Sandertv
Copy link
Owner

Fair enough, it should probably handle them yeah. I'll change it in a bit.

@Sandertv Sandertv added the enhancement New feature or request label Sep 10, 2019
@Sandertv
Copy link
Owner

The behaviour was changed in 01f9ef4. It now logs a message and continues handling the packet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants