Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Rubocop Guidelines Improvements #12

Merged

Conversation

brunoocasali
Copy link
Contributor

  • Removed all Rubocop offences
  • Specs passing
  • Fixed some found english errors
  • Changed the style of template file.
  • Many other fixes.

Thanks!

@zawaideh
Copy link
Member

zawaideh commented Aug 5, 2015

Looks good. If you can rebase, I'll merge it in.

@brunoocasali
Copy link
Contributor Author

Rebased! @zawaideh, thanks!

zawaideh pushed a commit that referenced this pull request Aug 5, 2015
@zawaideh zawaideh merged commit 20d6a0d into Sandglaz:master Aug 5, 2015
@brunoocasali brunoocasali deleted the feature/guidelines-improvements branch August 5, 2015 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants