Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the UI of Register screen uniform #8

Closed
Saransh-cpp opened this issue Nov 10, 2021 · 6 comments · Fixed by #51
Closed

Make the UI of Register screen uniform #8

Saransh-cpp opened this issue Nov 10, 2021 · 6 comments · Fixed by #51
Assignees
@raviyadav17
Labels
CodePeak hard Would require your time and patience refactor Refactor the code! SWoC ui/ux Editing the UI/UX

Comments

@Saransh-cpp
Copy link
Owner

Description

Right now the register screen looks really bad (well, the whole app looks really bad), for starters, we can try making the UI on a single screen a bit uniform.

  • Add white background in all the fields
  • Create a similar eye icon in confirm password field

Relevant screens

Register.dart

Screenshot

Note - You might also would need to refactor the code by creating a new widget (hence I am keeping this a moderate level issue)
@Saransh-cpp Saransh-cpp added moderate Moderate level issue ui/ux Editing the UI/UX refactor Refactor the code! labels Nov 10, 2021
@Saransh-cpp Saransh-cpp mentioned this issue Nov 10, 2021
Closed
@raviyadav17
Copy link
Contributor

Can I solve this issue?
Name : Ravi

@Saransh-cpp
Copy link
Owner Author

Sure, go ahead!

@raviyadav17
Copy link
Contributor

IS THIS UI OKAY

@Saransh-cpp
Copy link
Owner Author

Yes, looks good! Could you also decrease the width of the input fields? So that they don't take the complete width of a device.

@raviyadav17
Copy link
Contributor

**Done **

@Saransh-cpp
Copy link
Owner Author

Looks good! You can create a PR.

This was referenced Dec 3, 2021
Closed
Closed
@Saransh-cpp Saransh-cpp added hard Would require your time and patience and removed moderate Moderate level issue labels Dec 4, 2021
@raviyadav17 raviyadav17 mentioned this issue Dec 6, 2021
Merged
@Saransh-cpp Saransh-cpp linked a pull request Dec 8, 2021 that will close this issue
Make the UI of Register screen uniform #8 Issue Solved #25 #51
Merged
Saransh-cpp added a commit that referenced this issue Dec 8, 2021
@Saransh-cpp
Merge pull request #51 from raviyadav17/Updated-Register.dart
fd52795 
Make the UI of Register screen uniform #8 Issue Solved #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raviyadav17 raviyadav17

Labels
CodePeak hard Would require your time and patience refactor Refactor the code! SWoC ui/ux Editing the UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the UI of Register screen uniform #8 Issue Solved #25 raviyadav17/BookRentApp-Chapter3
2 participants
@Saransh-cpp @raviyadav17