-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the UI of Register screen uniform #8 Issue Solved #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @raviyadav17! Some comments below -
- Can you also refactor the input text fields? Completely fine if you want to take more time and completely fine if you don't want to (I'll have to make this an
easy
issue if you can't refactor)
Suggestion -
- Always give the branch a meaningful name (refer to
README.md
for the convention that we follow)
@@ -7,7 +7,7 @@ packages: | |||
name: async |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need changes in this file as a part of this PR. Can you revert them back? (Make sure you are on the branch from which you created this PR)
- Go back a commit (remove the commit but keep the staged changes)
git reset --soft HEAD~1
- Remove
pubspec.lock
from the staged files.
git restore --staged pubspec.lock
- Make a new commit.
git commit -m "<message>"
- Force push the changes (as the local and GitHub repos are out of sync, we removed a commit and created another one in its place)
git push -f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Can you please elaborate what "refactor the input fields" means ??
Does it mean to make the height value of field more small?? -
I did not update the pubspec.lock i guess it got automatically updated. But I will look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring means making a common widget for all the fields, in this case, there might be 2 common widgets. For example -
In this image, you can create a common widget for the "Name" and "email" fields, in which you can pass the input hint text and the icon (like creating a function, so that one doesn't repeat the same code twice).
Yes, pubspec.lock
is updated automatically. You must've added the files using git add .
. No worries, you can remove it with the commands specified above.
You can also keep pushing to your branch ad the commit will automatically appear on this PR. No need to open a new one.
There are some widgets available in the Widgets.dart file for your reference. I can make this a hard issue if you are very new to these concepts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed the above task.
Do i have to make function like this for password and confirm password ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i Comment the Input field now or Remove it?? As i have created a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to ask how to put SetState() in function??
Error: Method not found: 'setState'.
setState(() {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i Comment the Input field now or Remove it?? As i have created a function.
Remove it.
I want to ask how to put SetState() in function??
Can you create a PR? I'll look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed but in a new branch Refactor-Update
Register
screen uniform #8I am a part of Codepeak. Thank You