Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan on GhostBSD: OS "Unknown" Version "Unknown" #124

Open
Andreyogld3d opened this issue Jun 1, 2021 · 4 comments
Open

Vulkan on GhostBSD: OS "Unknown" Version "Unknown" #124

Andreyogld3d opened this issue Jun 1, 2021 · 4 comments

Comments

@Andreyogld3d
Copy link

Hi! we have empty string for GhostBSD(may be on FreeBSD)

VulkanCapsViewer/vulkancapsviewer.cpp

Line 79 in 7237fa5

OSInfo getOperatingSystem()

My suggestion:

#if !defined(_WIN32) && !defined(__ANDROID__)
#include <sys/utsname.h>
#endif

#if !defined(_WIN32) && !defined(__ANDROID__)
    struct utsname n;
    uname(&n);
    osInfo.name = n.sysname;
    osInfo.version = n.version;
#endif
@jbeich
Copy link

jbeich commented Jun 2, 2021 •
edited

Check if GhostBSD has freebsd/freebsd-ports@261ca51 or freebsd/freebsd-src@6467506
QSysInfo itself uses uname when /etc/os-release isn't supported, see qt/qtbase@7680108

@SaschaWillems
Copy link
Owner

Can you provide a pull request? I don't have any platform to test this on.

@Andreyogld3d
Copy link
Author

Yes, later, thanks for your answer @SaschaWillems

@Andreyogld3d Andreyogld3d mentioned this issue Jun 6, 2021
Closed
@Andreyogld3d
Copy link
Author

@SaschaWillems see #125

Andreyogld3d added a commit to Andreyogld3d/VulkanCapsViewer that referenced this issue Dec 6, 2022
@Andreyogld3d
Use POSIX uname function instead of QSysInfo for BSD Unix
438203f 
For GhostBSD we have OS "unknown" for Report.

https://vulkan.gpuinfo.org/displayreport.php?id=11527

We should use POSIX uname function instead of QSysInfo for BSD Unix

After fixing we have correct result:
https://vulkan.gpuinfo.org/displayreport.php?id=11577

Also, see SaschaWillems#124
@Andreyogld3d Andreyogld3d mentioned this issue Dec 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Andreyogld3d @SaschaWillems @jbeich