Tweak formatting of reported values #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krOoze
commented
Dec 15, 2019
•
krOoze
commented
- update some Flags and Enums
- show Flags consistently
- shows hex at flag root
- lists supported bits
- lists unknown supported bits with a hex
- show VID:PID in hex
- show UUID in canonical form
- show bool Limits as bool
- fix sampled counts as VkSampleCountFlagBits #1: show samples as a list of supported counts
- do not use Vk version format for revision numbers
- fix Bool color in Queues tab
- consistent array formatting
- show array size as C notation
- show index as C notation
- some random cleanup
krOoze
force-pushed
the
formatting
branch
3 times, most recently
from
d229356
to
293774d
Compare
|
Thanks for your PR. I haven't had time to review it yet, but will try to do so as soon as possible. One thing I noticed that some files, e.g. vulkancapsviewer.cpp is showing as completly different in the diff? Makes it a bit harder to review this pr. |
|
@SaschaWillems Hm, maybe I accidentally switched the endlines. I will give it a look. Meanwhile GitHub will show the right thing if you check "Hide whitespace changes". |
- update some Flags and Enums - show Flags consistently -- shows hex at flag root -- lists supported bits -- lists unknown supported bits with a hex - show VID:PID in hex - show UUID in canonical form - show bool Limits as bool - fix SaschaWillems#1: show samples as a list of supported counts - do not use Vk version format for revision numbers - fix Bool color in Queues tab - consistent array formatting -- show array size as C notation -- show index as C notation - some random cleanup
|
Fixed. Still not the shortest PR though. |
|
Looks good so far. Works fine on both Windows and Android. Thanks for your effort :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.