Added the missing package for abrt #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
|
ACK. Will leave it as it is for elyezer to merge. |
| ] | ||
| for package in packages: | ||
| run('yum install -y {0}'.format(package)) | ||
|
|
||
| run('systemctl restart foreman') | ||
| run('touch /usr/share/foreman/tmp/restart.txt') |
There was a problem hiding this comment.
The above will restart foreman, is there anything else touching the restart file does?
By having both foreman will be restarted twice.
There was a problem hiding this comment.
@elyezer it only restarts the foreman as per the discussion with the developer
There was a problem hiding this comment.
touch is either to create empty file or to change the timestamps of file..forman is already restarting at line 402
|
ACK, pending comment. |
elyezer
added a commit
that referenced
this pull request
Jan 12, 2015
Added the missing package for abrt
|
@tkolhar @elyezer @sghai @kbidarkar one minor but important issue here is that, if we add a workaround to our code, we have to make sure that:
|
|
@omaciel good point. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step is missing :
https://github.com/theforeman/foreman_abrt/blob/katello-docs/README.md#installing-the-foreman-plugin
Added as per the instructions given in README
please review it thanks