Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapstruct 추가 #14

Closed
Dae-Hwa opened this issue Aug 6, 2021 · 2 comments · Fixed by #32
Closed

Mapstruct 추가 #14

Dae-Hwa opened this issue Aug 6, 2021 · 2 comments · Fixed by #32
Assignees
@Dae-Hwa
Labels
chore🍙
Projects
Scoup 프로젝트

Comments

@Dae-Hwa
Copy link
Collaborator

Dae-Hwa commented Aug 6, 2021

No description provided.

@janeljs
Copy link
Contributor

janeljs commented Aug 6, 2021 •
edited by Dae-Hwa
Loading

참고 링크

Dae-Hwa added a commit that referenced this issue Aug 11, 2021
@Dae-Hwa
chore: 🤖 MapStruct 의존성 추가
a057566 
버전을 동시에 여러개 관리해야 하기 때문에 build.gradle에 mapstructVersion 변수로 추가하여 버전 관리
하도록 설정.

✅ Closes: #14
Dae-Hwa added a commit that referenced this issue Aug 11, 2021
@Dae-Hwa
feat: 🎸 UserMapper 추가
51ecdf6 
생성자 주입을 하도록 injectionStrategy = InjectionStrategy.CONSTRUCTOR 와 같이 설정.
그렇지 않을 경우 기본 전략이 프로퍼티라 setter가 필요할 수 있음.

✅ Closes: #14
Dae-Hwa added a commit that referenced this issue Aug 11, 2021
@Dae-Hwa
refactor: 💡 UserFactory 대신 UserMapper 사용하도록 변경
b76bdf3 
UserFactory는 더 이상 사용하지 않기 때문에 삭제

BREAKING CHANGE: 🧨 UserFactory.from 대신 UserMapper.signUpRequestToUser 사용

✅ Closes: #14
@Dae-Hwa Dae-Hwa linked a pull request Aug 11, 2021 that will close this issue
[Freddie] Mapstruct 추가 및 User에 적용 #32
Merged
@janeljs janeljs added this to To do in Scoup 프로젝트 via automation Aug 11, 2021
@janeljs janeljs added this to the W2 milestone Aug 11, 2021
@janeljs janeljs closed this as completed Aug 13, 2021
Scoup 프로젝트 automation moved this from To do to Done Aug 13, 2021
@Dae-Hwa
Copy link
Collaborator Author

Dae-Hwa commented Aug 13, 2021

의존성 주입 시Mapstruct의 어노테이션 프로세서가 롬복의 어노테이션 프로세서보다 위에 있어야함

Dae-Hwa added a commit that referenced this issue Aug 13, 2021
@Dae-Hwa
chore: 🤖 lombok mapstrcut binding 의존성 추가 및 lombok 순서 변경
382d6a3 
MapStruct의 annotation processor가 lombok의 annotaion processor보다 위에 있어야
제대로 작동

✅ Closes: #14
Dae-Hwa added a commit that referenced this issue Aug 13, 2021
@Dae-Hwa
refactor: 💡 불필요한 설정 제거
b6c011e 
builder.gradle에 Mastruct, Lombok 관련 설정으로 어노테이션 설정
필요없어짐.

✅ Closes: #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dae-Hwa Dae-Hwa

Labels
chore🍙
Projects
Scoup 프로젝트
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Freddie] Mapstruct 추가 및 User에 적용 Sc0up/scoup-backend
2 participants
@Dae-Hwa @janeljs