Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Freddie] Mapstruct 추가 및 User에 적용 #32

Merged
merged 6 commits into from
Aug 13, 2021
Merged

[Freddie] Mapstruct 추가 및 User에 적용 #32

merged 6 commits into from
Aug 13, 2021

Conversation

Dae-Hwa
Copy link
Collaborator

@Dae-Hwa Dae-Hwa commented Aug 11, 2021 •
edited by janeljs
Loading

참고 자료는 아래와 같습니다.

https://meetup.toast.com/posts/213 도 읽어볼만 한 것 같습니다.

@Dae-Hwa
chore: 🤖 MapStruct 의존성 추가
a057566 
버전을 동시에 여러개 관리해야 하기 때문에 build.gradle에 mapstructVersion 변수로 추가하여 버전 관리
하도록 설정.

✅ Closes: #14
@Dae-Hwa
feat: 🎸 UserMapper 추가
51ecdf6 
생성자 주입을 하도록 injectionStrategy = InjectionStrategy.CONSTRUCTOR 와 같이 설정.
그렇지 않을 경우 기본 전략이 프로퍼티라 setter가 필요할 수 있음.

✅ Closes: #14
@Dae-Hwa
refactor: 💡 UserFactory 대신 UserMapper 사용하도록 변경
b76bdf3 
UserFactory는 더 이상 사용하지 않기 때문에 삭제

BREAKING CHANGE: 🧨 UserFactory.from 대신 UserMapper.signUpRequestToUser 사용

✅ Closes: #14
@Dae-Hwa Dae-Hwa linked an issue Aug 11, 2021 that may be closed by this pull request
Mapstruct 추가 #14
Closed
@janeljs janeljs changed the title Mapstruct 추가 및 User에 적용 [Freddie] Mapstruct 추가 및 User에 적용 Aug 11, 2021
@janeljs janeljs added this to the W2 milestone Aug 11, 2021
janeljs
janeljs approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@janeljs janeljs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapstruct는 이렇게 사용하는 거군요!ㅎㅎ 신기하네요. 먼저 알아봐주셔서 감사합니다.

src/main/java/com/postsquad/scoup/web/user/mapper/UserMapper.java Show resolved Hide resolved
@Dae-Hwa
chore: 🤖 lombok mapstrcut binding 의존성 추가 및 lombok 순서 변경
382d6a3 
MapStruct의 annotation processor가 lombok의 annotaion processor보다 위에 있어야
제대로 작동

✅ Closes: #14
@Dae-Hwa
refactor: 💡 불필요한 설정 제거
b6c011e 
builder.gradle에 Mastruct, Lombok 관련 설정으로 어노테이션 설정
필요없어짐.

✅ Closes: #14
@Dae-Hwa
Merge branch 'main' into apply-mapstruct
ddd8d86
@Dae-Hwa Dae-Hwa merged commit fab7e69 into main Aug 13, 2021
@Dae-Hwa Dae-Hwa deleted the apply-mapstruct branch August 13, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeljs janeljs janeljs approved these changes

@sallyjellyy sallyjellyy sallyjellyy approved these changes

Assignees
No one assigned
Labels
new feature✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mapstruct 추가
3 participants
@Dae-Hwa @sallyjellyy @janeljs