chore(deps): update js test packages to v29 (major) #303
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/major-js-test-packages
branch
2 times, most recently
from
080d9cb
to
acb6166
Compare
renovate
bot
force-pushed
the
renovate/major-js-test-packages
branch
2 times, most recently
from
63f8736
to
39b7dc4
Compare
renovate
bot
force-pushed
the
renovate/major-js-test-packages
branch
from
39b7dc4
to
3e41d2b
Compare
nguyentoanit
force-pushed
the
renovate/major-js-test-packages
branch
from
d284328
to
af56ceb
Compare
|
@moltar : Any idea to resolve these errors? |
|
No idea, sorry |
New issue which relate to Jest coverage 😄 . This didn't happen locally. 🤷 |
|
Looks like This is a Jest issue: kulshekhar/ts-jest#3691 |
Do you mean codecov? |
src/config.ts
Outdated
| @@ -34,7 +34,7 @@ export class JestPollyConfigService { | |||
|
|
|||
| // eslint-disable-next-line class-methods-use-this | |||
| private factory(): PollyConfigWithSecrets { | |||
| const recordingsRoot = path.dirname(expect.getState().testPath) | |||
| const recordingsRoot = path.dirname(expect.getState().testPath ?? '.') | |||
There was a problem hiding this comment.
I think better would be to default to process.cwd() here?
Yeah. Codecov CI was failed. Jest threw an error inside that CI. |
| import { Polly } from '@pollyjs/core' | ||
|
|
||
| import { jestPollyConfigService, jestPollyContext } from '.' | ||
| import { JestPollyConfigService } from './config' | ||
|
|
||
| describe('index', () => { | ||
| it('exports polly instance', () => { | ||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| it.skip('exports polly instance', () => { |
There was a problem hiding this comment.
Strange here. 🤔
index › exports polly instance
expect(received).toBeInstanceOf(expected)
Expected constructor: Polly
Received constructor: Polly
10 | expect.assertions(1)
11 |
> 12 | expect(jestPollyContext.polly).toBeInstanceOf(Polly)
| ^
13 | })
14 |
15 | it('exports polly config service', () => {
at Object.<anonymous> (src/index.test.ts:12:36)
```
There was a problem hiding this comment.
Yes, saw that too. Really really strange! No idea 🤷🏼
There was a problem hiding this comment.
@moltar : Commented it out. 😞
Codecov ReportBase: 81.81% // Head: 81.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 81.81% 81.81%
=======================================
Files 6 6
Lines 110 110
Branches 24 25 +1
=======================================
Hits 90 90
+ Misses 20 17 -3
- Partials 0 3 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
we were using Node.js v12 for Codecov. Perhaps, they weren't supported and threw an exception. 😄 |
|
🎉 This PR is included in version 1.5.66 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates:
27.0.3->29.1.126.6.3->29.1.226.5.6->29.0.3Configuration
📅 Schedule: Branch creation - "before 3am on the first day of the month" in timezone Etc/UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.