Separated to two constructors #346
Conversation
There was a problem hiding this comment.
I would have been great to have a singlePrimitive : Boolean parameter on Geometry so we can apply the same single material to all the Geometrybut it's a good start. For example, in case on textured one we want to apply all around the geometry without repeating it.
Could you please just make the material optional (nullable) so we don't apply any if not required?
Thanks
| @@ -25,7 +21,7 @@ open class CubeNode( | |||
| * Should return the material to bind for the zero-based index of the primitive, must be less | |||
| * than the [Geometry.submeshes] size passed to constructor. | |||
| */ | |||
| materialInstances: (index: Int) -> MaterialInstance? = { materialInstance }, | |||
| materialInstances: (index: Int) -> MaterialInstance, | |||
There was a problem hiding this comment.
Why moving it to non nullable?
It could be usefull in case only some faces requiring material.
Same for every Geometries they could be used for collision purposes.
There was a problem hiding this comment.
I thought a face must be attached with a material. It is fixed now.
| /** | ||
| * Binds a material instance to all primitives. | ||
| */ | ||
| materialInstance: MaterialInstance, |
There was a problem hiding this comment.
Should also be nullable for every geometries.
I don't think |
|
You're right but if we take the image texture example, actually, if we want to apply it to let say a Cube, we will have the same image displayed on each face and no way to have the same single image applied all around the Cube (each face displaying a part of the image). |
Separated BaseGeometryNode to two constructors. One with
materialInstancethat binds a material instance to all primitives, while the other withmaterialInstancesthat binds one material instance to each face.