New TOML Schemas: Add various schemas from Taplo #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
changed the title
for more information, see https://pre-commit.ci
|
Thanks |
They pass because of a lack of top-level The schemas will need to be merged. Edit: I've added negative tests to my branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds variuos schemas for TOML files from the Taplo repository. The project is deprecating its own schemas, in favor of moving them over here.
I'll note that there are various Taplo-specific properties, which I have added to the
"unknownKeywords"property - I assume they are OK since I've seen other Intelij-specific keywords as well?This would close #2327. This PR also includes a schema for
pyproject.toml, so I'm not sure how that should be handled since PR #2365 also adds that schema. I have copied and pasted the test files from that PR into this PR, and they seem to pass against this version of thepyproject.tomlschema as well.