GitHub Workflow schema #853
Conversation
there is more stuff feasible than documented (see https://github.com/calibreapp/image-actions#how-to-add-this-to-your-repository)
|
I think there is an error with the on:
push:
branches:
- 'master'
- 'develop'
paths:
- 'path/to/file.ext'Red squiggle lines beneath [EDIT] |
|
Defining services for a job also gives a warning about a missing property "image": jobs:
build:
name: Install, Build & Test
runs-on: ubuntu-latest
services:
redis:
image: redis
ports:
- 6379/tcp
options: --health-cmd trueHere |
|
@riker09 Thanks, I didn't know about the thread. Just fixed everything you mentioned and some extra stuff. Edit: hang on, missed a thing... |
|
I think it's good to go now. |
|
There are merge conflicts. Once resolved, I'll merge the PR. And thank you!!! |
|
@madskristensen done |
|
Great. Thank you again |
|
I'm glad to help. Feel free to @ me if any issue is raised. |
* Create github-workflow.json * added to catalog * fixed environmental variables not being able to receive numbers as input * removed jobs.steps.uses pattern there is more stuff feasible than documented (see https://github.com/calibreapp/image-actions#how-to-add-this-to-your-repository) * fixed "on" always expecting object * fixed catalog listing missing url * typo * fixed services/container mapping * fixed services/container.ports not allowing string example: "80/tcp" * fixed branches/tags (ignore) not being allowed for push/pull_request events * fixed types not allowing in push and pull_request events * push and pull_request filters are now suggested
|
A lot of checks here are unexpectedly ignored due to schema version and incorrect Thanks to @Aplietexe for noticing that |
| "$comment": "https://help.github.com/en/github/automating-your-workflow-with-github-actions/events-that-trigger-workflows#check-run-event-check_run", | ||
| "$ref": "#/definitions/eventObject", | ||
| "description": "Runs your workflow anytime the check_run event occurs. More than one activity type triggers this event. For information about the REST API, see https://developer.github.com/v3/checks/runs.", | ||
| "properties": { |
There was a problem hiding this comment.
This is no-op per spec in draft-07 (which is used here), and that is verified in implementations as the upstream testsuite checks for sibling props to $ref being noops.
Based on the official documentation.
Also, see #850 for the action schema.