-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added init container to fix permissions #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. @Langhalsdino,
thanks for the contribution! I had this on my todo list!
Can you do me a favour and add feat: Added init container to fix permissions
to the commit message?
And sign it off to.
Easy to do with:
git rebase -i HEAD~2
<chose reword>
git commit --amend -s
git push origin --force
```
All in your branch! Thanks, then I can merge it and release it instantly!
Thanks for the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Thank you for your comments, i tried to integrate everything and hopefully succeed rebasing the comments and choosing a useful commit message. |
I squashed the commits, sorry for the inconvenience with the multiple commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Langhalsdino, thanks for the changes!
I left one little thing to change, and then we are good to merge!
updated chart version and modified change log feat: Added init container to fix permissions Signed-off-by: Langhalsdino <github@tausch.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Langhalsdino,
thanks for your contribution! Much appreciated!
This pull request added an init container to the deployment.yml.
The #22 shows that this is a bug, when using persistent volume claims, since their permission is incorrect and need to be changed.
Try the fix
While the values.yml is defined as follows: