Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll bug in OnyxNavBar mobile mode when you have too many NavItems #1483

Closed
10 tasks done
MajaZarkova opened this issue Jul 2, 2024 · 1 comment · Fixed by #1559
Closed
10 tasks done

Fix scroll bug in OnyxNavBar mobile mode when you have too many NavItems #1483

MajaZarkova opened this issue Jul 2, 2024 · 1 comment · Fixed by #1559
Assignees
Labels
bug Something isn't working or not shown correctly dev Requires technical expertise

Comments

@MajaZarkova
Copy link
Contributor

MajaZarkova commented Jul 2, 2024

Image

  • fix mobile nav parent highlighting
    • parent is hidden if parent is not clickable -> add storybook example
    • in the drilled-down level, the parent should not be highlighted if a child is active

Image

@BoppLi
Copy link
Contributor

BoppLi commented Jul 12, 2024

For review, show

  • overflowing menu content
    • open menu: it now scrolls with many nav buttons
    • open "Item 2": it scrolls with many nav items/children
    • open context menu:
      • it scrolls on many context options
      • the app version is not sticky anymore
      • there are no double borders between options
  • updated Storybook example
    • Item 2 is not highlighted when opened, only its active child is highlighted
    • Item 3 is hidden when opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or not shown correctly dev Requires technical expertise
Projects
Status: Done
2 participants