Skip to content
This repository has been archived by the owner on Jan 27, 2020. It is now read-only.

Follow Strelka BP and use Manta small indels candidates as input #556

Merged
merged 7 commits into from
Apr 3, 2018

Conversation

maxulysse
Copy link
Member

new PR to replace #467
This is deactivated by default.
So it should be safe to merge if we want to try this new feature

@maxulysse maxulysse changed the title Follow Strelka BP and use Manta small indels candidates Follow Strelka BP and use Manta small indels candidates as input Mar 27, 2018
@maxulysse
Copy link
Member Author

I think I can add this option for Germline as well, so do not merge yet.

@maxulysse
Copy link
Member Author

So bad idea to try to implement for germline, I should have read further.

The germline caller already includes its own assembly step, so indel candidate input from a tool like Manta is not recommended in this case (in testing, Manta candidate indels have been found to provide no benefit and in some cases may complicate the accurate resolution of a locus).

At least I read it before starting to do some work on it.

Copy link
Collaborator

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@szilvajuhos szilvajuhos merged commit 2c40e28 into SciLifeLab:master Apr 3, 2018
@szilvajuhos
Copy link
Collaborator

Eventually we could check on real data whether it improves indel calls.

@maxulysse maxulysse deleted the StrelkaBP branch April 3, 2018 07:55
@maxulysse
Copy link
Member Author

Of course, that why for the moment it's not working by default, but I hope to definitively use this functionality.
We can provide both VCFs from Strelka, for the moment, we now do have two different directories, so it'll be easy to check it out

jherrero referenced this pull request in UCL-BLIC/Sarek_v2.2.1 Apr 11, 2019
Follow Strelka BP and use Manta small indels candidates as input
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants