This repository has been archived by the owner on Jan 27, 2020. It is now read-only.
Preparing new release #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be a conflict for CHANGELOG. I guess it's due to my recent PR. |
alneberg
suggested changes
Sep 13, 2018
| - [#615](https://github.com/SciLifeLab/Sarek/pull/615) - Add presentation | ||
| - [#615](https://github.com/SciLifeLab/Sarek/pull/615) - Update documentation | ||
| - [#620](https://github.com/SciLifeLab/Sarek/pull/620) - Add `tmp/` to `.gitignore` | ||
| - [#625](https://github.com/SciLifeLab/Sarek/pull/625) - Add [`pathfindr`](https://github.com/NBISweden/pathfindr) as a submodule |
There was a problem hiding this comment.
You're obsessed with whitespace changes.
There was a problem hiding this comment.
Just notice there was a beautifier in atom, so run it on CHANGELOG
|
I preferred not to list this new documentation in our README, since it will mainly be used by us only. |
|
That's fine. Nothing that forces you to have all the documentation in the
readme.
Den 13 sep. 2018 13:10 skrev "Maxime Garcia" <notifications@github.com>:
I preferred not to list this new documentation in our README, since it will
mainly be used by us only.
Are you OK with that?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#640 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABMTG3IGsy0C38V-DDl7sm8gyQiVyHw0ks5uaj0tgaJpZM4Wli_N>
.
|
|
Great job! Let's merge! |
alneberg
approved these changes
Sep 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
devbranch./scripts/test.sh -p docker -t ALL).CHANGELOG.mdis updated