Quickfix: json parsing needs exception handling #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
self.merge() |
remiolsen
added a commit
that referenced
this pull request
Jul 9, 2014
Quickfix: json parsing needs exception handling
|
Is there any way that these sorts of exceptions can be logged somewhere along with the pass? That way the script will continue to run, but we will still know that these errors are occurring.. |
|
Agree, maybe the exception can be allowed to propagate back to the calling function which would have a try-except to deal with it? That could even just be logging. There doesn't appear to be any logging in this particular file I guess because it's mostly just classes. I don't know this code that well though, maybe that's easier said than coded... |
kate-v-stepanova
pushed a commit
to kate-v-stepanova/genomics-status
that referenced
this pull request
Aug 31, 2015
Quickfix: json parsing needs exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.