Promote ReverseDiff compile field to type #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vaibhavdixit02
approved these changes
Jun 22, 2024
6 tasks
gdalle
requested changes
Jun 22, 2024
ChrisRackauckas
approved these changes
Jun 22, 2024
|
One change, getproperty overload to add a depwarn on accessing the boolean. We'll want people to move to the type stable form, though there's no reason to force the change immediately (and that depwarn should probably be given at least a year or two given that the feature has been around since 2020) |
|
Yes it is breaking, see #63 (comment) |
How though? ad.compile is a Bool as it always was. |
|
Oh sorry I missed that part, thought you stored the Val directly. Then it's fine |
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for things like LuxDL/Lux.jl#642 where the return type needs to rely on whether the compiled tape needs to be returned.