-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README example should use interpolation instead of indexing #107
Comments
The issue is more that the model is a bit nonsense and you're not testing what the model is actually saying. You're testing that the value in the middle has a value, i.e.: function bc!(residual, u, p, t)
residual[1] = u(0.75)[1] + pi / 2
residual[2] = u[end][1] - pi / 2
end But that's not the model. The model is that the middle of the solve array is |
Yeah, we should not expect the value in the middle to be the same since the adaptive time steppings, but the two solutions from different solvers are quite different, I think there is something wrong about this, especially the shooting method. |
There's nothing wrong about the solutions. The |
Oh I see, I will propose a better example for the detailed usage of BVP solvers.
I remembered OrdinaryDiffEq.jl can use interpolations, is there some text we can refer to add this feature to MIRK solvers? |
No, this is a good example, it's just that every multi-point example should use interpolation.
The MIRK solvers already define the interpolation for the residual calculation. |
While trying
MIRK
solvers andShooting
solvers with example problem in README, the two kinds of solvers gave two different solutions:Solution from MIRK(Correct):
Solution from Shooting(Wrong):
The text was updated successfully, but these errors were encountered: