Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event repeated at the same time using ContinuousCallback and adaptive = false #590

Closed
BeastyBlacksmith opened this issue Apr 8, 2020 · 2 comments · Fixed by SciML/DiffEqBase.jl#476
Closed

Event repeated at the same time using ContinuousCallback and adaptive = false #590

BeastyBlacksmith opened this issue Apr 8, 2020 · 2 comments · Fixed by SciML/DiffEqBase.jl#476

Comments

@BeastyBlacksmith
Copy link

The following used to work on julia 1.1 with OrdinaryDiffEq v5.16.0, but fails on 1.4 with OrdinaryDiffEq v5.33.0:

using Pkg
Pkg.add("https://gitlab.gwdg.de/PhD/VesiclesForms.jl/")
vesicle = VesicleForms.critSphere
        sol = VesicleForms.integrate_shapeEquations( vesicle, (0.0,1.2), callback = VesicleForms.pi_callback, adaptive = false, alg = Vern7() )

Removing either the callback or the adaptiveness, does not error, but also does not produce the desired result.
@ChrisRackauckas
Copy link
Member

Probably related to some of the @kanav99 callback changes. Diagnosing this is very subtle though, so wait a few days and we'll figure out what's going on.

@kanav99 kanav99 mentioned this issue Apr 9, 2020
Merged
@ChrisRackauckas
Copy link
Member

Sorry, this got accidentally closed when I accidentally merged, but the real fix is coming in SciML/DiffEqBase.jl#487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bisection to make it not return tprev SciML/DiffEqBase.jl
2 participants
@ChrisRackauckas @BeastyBlacksmith