-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector#set doesn't work for Category vectors #390
Comments
@zverok Yes, |
@zverok @lokeshh I added these lines of code. It showed some error but did the work. The problem is that the def set indexes, val
@index = @index.add(indexes)
@cat_hash.store(val,[indexes])
@array << indexes
modify_category_at indexes, val
end
|
ping! @zverok @lokeshh @athityakumar |
@rohitner When you do |
@rohitner It would be better if you could create a PR and we discuss it there. |
I believe the reason is category vector, while imitating being the same vector, cleans up
@data
variable. Probably it is not the only broken method for category vectors.Showcased by #388
@lokeshh WDYT?
The text was updated successfully, but these errors were encountered: