Allowed __repr__ of a poorly constructed Unit. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
bjlittle
reviewed
Jan 22, 2019
| @@ -1128,7 +1128,7 @@ def is_unknown(self): | |||
| False | |||
|
|
|||
| """ | |||
| return self.category == _CATEGORY_UNKNOWN | |||
| return self.category == _CATEGORY_UNKNOWN or self.ut_unit is None | |||
There was a problem hiding this comment.
@pelson Could self.ut_unit also be _ud.NULL_UNIT? If so, does this need to be included here in this check?
There was a problem hiding this comment.
The only way it can be NULL_UNIT is if the constructor succeeded and it is one of _NO_UNIT or _UNKNOWN_UNIT.
We shouldn't consider "no unit" unknown, so the only case that it can be NULL_UNIT is if self.category == _CATEGORY_UNKNOWN.
In summary, I don't think so.
|
Thanks @pelson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Addresses the comment in #133 (comment), namely that pytest tries calling
Unit.__repr__when a test fails, even if that test was the constructor ofUnit. Essentially, unless pytest-dev/pytest#4659 is solved directly, we should strive to have a repr that can be a little more fault tolerant (rather than Segmentation Faulting as it currently does).Implications
is_unknownnow also checks to see if theut_unitpointer is None, if it is, the unit is considered unknown.