Soft deps in setup #123
Merged
Soft deps in setup #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide runtime checks for 'soft; dependency on Iris 2.1.
|
@pp-mo This is a really nice solution. Nice one. |
pp-mo
reviewed
Jun 14, 2018
iris_grib/_load_convert.py
Outdated
| @@ -43,6 +43,7 @@ | |||
| ReferenceTarget | |||
| from iris.util import _is_circular | |||
|
|
|||
| from . import _confirm_iris_mercator_support | |||
There was a problem hiding this comment.
Sorry this seems to be bugged.
I think it should really be from .. import ??
Always a bit confused by relative imports ! 😕
There was a problem hiding this comment.
I think it works though, but now it can't find grib_phenom_translation. Weird...
Yikes, I created a circular import problem ! |
Move mercator version-check to its own submodule, to avoid import problems.
|
@kaedonkers Ping! |
|
@bjlittle Ping |
Seconded -- can someone who is not me take a look please ?!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popped a little function in the setup.py to look for iris 2.1 because that would be best, but if it's not available then it will install using iris 2.0 (or later).
Also added the eccodes dependency. gribapi lives in python-eccodes, but I guess the (official?) package name is actually just eccodes.