Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0x19 docs update #370

Merged
merged 8 commits into from Jan 11, 2024
Merged

v0x19 docs update #370

merged 8 commits into from Jan 11, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Dec 14, 2023

Pulled in the recent docs fix from main.
Update the front-page version number and the release notes page to the v0.19 state -- which was not done at v0.19.0 release.

Intending to tag this as v0.19.1, to get a sensible docs-build up (and which will become the 'stable' endpoint).
Will then merge back (though now expecting to generate some conflicts).

@pp-mo pp-mo changed the title V0x19 docsupdate v0x19 docs update Dec 14, 2023
@pp-mo
Copy link
Member Author

pp-mo commented Dec 14, 2023

NOTE:
TBH I'm not sure if it's worth continuing to write manual release notes like this.
But it seems simpler just to go along with it for now.

@pp-mo pp-mo requested a review from lbdreyer December 15, 2023 15:42
@pp-mo
Copy link
Member Author

pp-mo commented Dec 15, 2023

Hi @lbdreyer any chance you can check this out ?
As stated, I'm trying to update the docs (mostly just release notes) to reflect the v0.19 release,
and then publish that via RTD : I reckon just cutting v0.19.1 will be the most honest way.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things, but generally looks good, thanks @pp-mo

docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
.readthedocs.yml Outdated Show resolved Hide resolved
Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>
.readthedocs.yml Outdated Show resolved Hide resolved
@pp-mo
Copy link
Member Author

pp-mo commented Jan 11, 2024

Thanks @ESadek-MO
Now made those changes -- let's see if it passes.

UPDATE:
missed one -- now done
waiting again!

Co-authored-by: Elias <110238618+ESadek-MO@users.noreply.github.com>
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pp-mo, this looks good to me!

@ESadek-MO ESadek-MO merged commit 72ef90d into SciTools:v0.19.x Jan 11, 2024
6 checks passed
HGWright added a commit to HGWright/iris-grib that referenced this pull request Apr 11, 2024
* upstream/main:
  Improve pre-commit compliance (SciTools#406)
  Add pre-commit config (SciTools#400)
  pdt6 & gdt140 take *three* (SciTools#401)
  v0x19 docs update (SciTools#370)
  bump feature branch to release version 0.19.0 (SciTools#364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants