Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit config #400

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Add pre-commit config #400

merged 2 commits into from
Apr 10, 2024

Conversation

trexfeathers
Copy link
Contributor

Closes #388

@trexfeathers
Copy link
Contributor Author

Once this is merged, I have the necessary permissions to activate pre-commit.ci on iris-grib

HGWright
HGWright requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers. Just a couple of minor changes since we do not have some of the config required for a couple of these tools.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
HGWright
HGWright approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! @trexfeathers

@HGWright HGWright merged commit 9a15adc into SciTools:main Apr 10, 2024
7 checks passed
@trexfeathers
Copy link
Contributor Author

Once this is merged, I have the necessary permissions to activate pre-commit.ci on iris-grib

image

✔

@trexfeathers trexfeathers mentioned this pull request Apr 10, 2024
Merged
HGWright added a commit to HGWright/iris-grib that referenced this pull request Apr 11, 2024
@HGWright
Merge remote-tracking branch 'upstream/main' into pyproj
6e9cf2f 
* upstream/main:
  Improve pre-commit compliance (SciTools#406)
  Add pre-commit config (SciTools#400)
  pdt6 & gdt140 take *three* (SciTools#401)
  v0x19 docs update (SciTools#370)
  bump feature branch to release version 0.19.0 (SciTools#364)
@trexfeathers trexfeathers mentioned this pull request Apr 16, 2024
Closed
@trexfeathers trexfeathers linked an issue Apr 16, 2024 that may be closed by this pull request
iris-grib codespell #390
Closed
@trexfeathers trexfeathers mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HGWright HGWright HGWright approved these changes

Assignees
No one assigned
Labels
Type: Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iris-grib codespell iris-grib pre-commit-config
2 participants
@trexfeathers @HGWright