Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mpl 1.2 rc2 #109

Merged
merged 22 commits into from
Sep 25, 2012
Merged

Mpl 1.2 rc2 #109

merged 22 commits into from
Sep 25, 2012

Conversation

pelson
Copy link
Member

@pelson pelson commented Sep 24, 2012

  • Makes the extests pass with matplotlib 1.2 rc2. (with one obvious exception)
  • Adds a swanky new idiff tool.

Remaining tests probably preferable to do in bunches (of modules).

@pelson
Copy link
Member Author

pelson commented Sep 24, 2012

To see all image diffs: try this

@bblay
Copy link
Contributor

bblay commented Sep 25, 2012

Two more pull requests added for this branch:

However, there are still two remaining image result failures in test_cmap_norm.
If this pull request is accepted, we'll need a bug raised for them.

@bblay
Copy link
Contributor

bblay commented Sep 25, 2012

Outstanding issues:

  • Unacceptable test_cmap_norm image changes.

I suggest we merge this in so #67 can progress.
I believe one, or both of the the unacceptable cmap images are fixed by that branch.

When merging this, we need to make two new Iris issues for the failing tests:

  • pcolormesh edge colours in test_mapping
  • test_cmap_norm image results

@bblay
Copy link
Contributor

bblay commented Sep 25, 2012

@pelson pelson changes ok and tested

bblay added a commit that referenced this pull request Sep 25, 2012
Tests now run with matplotlib 1.2.0 rc2
@bblay bblay merged commit 6d94d15 into SciTools:master Sep 25, 2012
@esc24
Copy link
Member

esc24 commented Sep 26, 2012

@bblay - that's an awful lot of commits in the history. In future I believe we should consider squashing lengthy pull requests like these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants