-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcolormesh bug: edgecolor ignored #1302
Comments
@bblay Thanks for pointing this out.
|
Note the difference: "edgecolor" and "edgecolors" |
In other words, the bug probably is that we aren't triggering an error for passing in "edgecolor", since the documentation states that it should be "edgecolors". |
Also, I would imagine that "facecolor" makes no sense for the pcolor family of functions, but that is just my own opinion. "facecolor" is not mentioned in the documentation for those functions, AFAICT. |
Confirmed. The following code fails to produce a quadmesh with red edges:
(they are colored by the data). Workaround:
There are some fundamental flaws with the way this has been implemented, and fixing them will break existing code. I suggest that this goes into the known bugs milestone for 1.2, and we address it in 1.3. @mdboom & @efiring : I think you two have most exposure to the QuadMesh collection; do you agree with this, or would you like me to fix this and slip it in to 1.2? (I could have a PR ready in <24 hrs) Full disclosure: @bblay and I are colleagues. |
This is still an issue on master. Tagged an 1.4, but this is a candidate to slip to 1.5 as it never seems to have worked. |
punting (again) |
@pelson do you remember what your proposed fix was, and what it would break? And what were the "fundamental flaws"? I suspect we should have taken you up on your offer to generate a PR. |
Unfortunately I don't. Logically it seems that an edgecolor of 'none', 'face', a specific color or an array are all supportable behaviour which should work. It might be worth investigating again and putting forward a proposed solution. |
Just confirming this bug in 1.4.3, has this been fixed in 1.5.0? |
Both pcolormesh and pcolor use colormapping based on the input array for the edges when the |
I believe the following code should produce grey edges but they have colour.
The text was updated successfully, but these errors were encountered: