Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File versions display update #1255

Closed
wants to merge 4 commits into from
Closed

File versions display update #1255

wants to merge 4 commits into from

Conversation

bitlogik
Copy link
Contributor

@bitlogik bitlogik commented Jul 9, 2020

Quickly fix #1220

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1255 into master will increase coverage by 18.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1255       +/-   ##
===========================================
+ Coverage   66.95%   85.02%   +18.06%     
===========================================
  Files         243      243               
  Lines       22501    22504        +3     
===========================================
+ Hits        15065    19133     +4068     
+ Misses       7436     3371     -4065     
Impacted Files Coverage Δ
parsec/core/gui/file_history_widget.py 80.18% <75.00%> (+55.91%) ⬆️
parsec/core/fs/userfs/userfs.py 86.57% <0.00%> (-0.23%) ⬇️
parsec/backend/invite.py 91.84% <0.00%> (+0.30%) ⬆️
parsec/core/fs/remote_loader.py 83.80% <0.00%> (+0.40%) ⬆️
parsec/core/fs/exceptions.py 98.41% <0.00%> (+0.79%) ⬆️
parsec/core/fs/workspacefs/versioning_helpers.py 99.13% <0.00%> (+0.86%) ⬆️
parsec/core/fs/workspacefs/workspacefs.py 96.83% <0.00%> (+0.94%) ⬆️
parsec/core/invite/greeter.py 88.63% <0.00%> (+1.13%) ⬆️
parsec/core/remote_devices_manager.py 77.88% <0.00%> (+1.92%) ⬆️
parsec/logging.py 72.09% <0.00%> (+2.32%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4474452...372e35a. Read the comment docs.

@vxgmichel vxgmichel requested a review from Max-7 July 10, 2020 08:38
@bitlogik
Copy link
Contributor Author

We forget that English is not the only language. So this requires some GUI translation. Like _("TEXT_FILE_CREATION"). Or we can use TEXT_FILE_CREATED_HEADER so the string is already present and translated in gui/tr.
It would display : "Version Created" if version == 1 (when dir or 0 size)
Then Version 1, Version 2, ...

@bitlogik
Copy link
Contributor Author

I guess that we have the work here to do again. As this looks fully in conflict with #1283

@bitlogik
Copy link
Contributor Author

OK so the #1283 fix doesn't conflict with this pull request. Still, as it added a test about the displayed version, this pull request will be amended so that it makes this test pass. I think especially at this
https://github.com/Scille/parsec-cloud/pull/1283/files#diff-cb0f3b4073387b5cd7dd2f50c117b185R101
Which should be replaced by "data creation" or _("TEXT_FILE_HISTORY_CREATION")

Is there "_" tr function in the tests? Are the tests in English GUI ?

@bitlogik
Copy link
Contributor Author

Is there "_" tr function in the tests?
Not sure, but all GUI tests are checked against plain English without tr _
Are the tests in English GUI ? Yes

We updated this pull request according to the answers above.
It was marked as "passed" before, because it was based on an incompatible head. This rebase including the updated test should handle the stuff.

@FirelightFlagboy FirelightFlagboy added the stale When something is outdated / old without any movement label Jun 22, 2022
@vxgmichel vxgmichel closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale When something is outdated / old without any movement
Projects
No open projects
Dev Board
Awaiting triage
Development

Successfully merging this pull request may close these issues.

File version display confusing
3 participants