-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File versions display update #1255
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
===========================================
+ Coverage 66.95% 85.02% +18.06%
===========================================
Files 243 243
Lines 22501 22504 +3
===========================================
+ Hits 15065 19133 +4068
+ Misses 7436 3371 -4065
Continue to review full report at Codecov.
|
We forget that English is not the only language. So this requires some GUI translation. Like _("TEXT_FILE_CREATION"). Or we can use TEXT_FILE_CREATED_HEADER so the string is already present and translated in gui/tr. |
I guess that we have the work here to do again. As this looks fully in conflict with #1283 |
OK so the #1283 fix doesn't conflict with this pull request. Still, as it added a test about the displayed version, this pull request will be amended so that it makes this test pass. I think especially at this Is there "_" tr function in the tests? Are the tests in English GUI ? |
Is there "_" tr function in the tests? We updated this pull request according to the answers above. |
Quickly fix #1220