Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed underscores in package names. #2930

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Allowed underscores in package names. #2930

merged 2 commits into from
Feb 22, 2019

Conversation

excitoon
Copy link
Contributor

@excitoon excitoon commented Dec 27, 2018 •
edited
Loading

For example: gcc-x86_64 (this is not host architecture, which can be expressed by -a, but target one).

@r15ch13
Copy link
Member

r15ch13 commented Jan 14, 2019

Please add a test case to https://github.com/lukesampson/scoop/blob/master/test/Scoop-Core.Tests.ps1#L258

@excitoon
Copy link
Contributor Author

Okay.

@Ash258 Ash258 mentioned this pull request Feb 14, 2019
Merged
@excitoon excitoon force-pushed the allowed-underscore-in-package-names branch from 7eaf600 to 41a11d5 Compare February 21, 2019 11:58
@excitoon excitoon force-pushed the allowed-underscore-in-package-names branch from 41a11d5 to eac2526 Compare February 21, 2019 12:00
@excitoon
Copy link
Contributor Author

@r15ch13 I'm finally finished it. Please check if it is fine.

@r15ch13 r15ch13 merged commit da64301 into ScoopInstaller:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@excitoon @r15ch13