Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoupdate): Handle xml namespace in xpath mode #3465

Merged
merged 2 commits into from
May 15, 2019
Merged

fix(autoupdate): Handle xml namespace in xpath mode #3465

merged 2 commits into from
May 15, 2019

Conversation

chawyehsu
Copy link
Member

@r15ch13
Copy link
Member

r15ch13 commented May 15, 2019

Ah, I was on the right track with the namespace thing in my old test branch 😄

@r15ch13 r15ch13 merged commit 765706c into ScoopInstaller:develop May 15, 2019
@chawyehsu chawyehsu deleted the patch-2 branch May 15, 2019 15:05
@chawyehsu
Copy link
Member Author

It took me 2 hours to find the way to resolve the issue of xml namespace without giving the power to users to control the namespace input.

@Ash258
Copy link
Contributor

Ash258 commented May 15, 2019

Excelent 🎉😍

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chawyehsu @r15ch13 @Ash258