Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decompress): fix bugs on extract_dir #3540

Merged
merged 2 commits into from
Jul 24, 2019
Merged

fix(decompress): fix bugs on extract_dir #3540

merged 2 commits into from
Jul 24, 2019

Conversation

issaclin32
Copy link
Member

This fixes the error when extract_dir contains spaces, such as "ISLC v1.0.1.2"
(encountered in: ScoopInstaller/Extras#2398)

Please let me know if there are any problems. Thanks.

@Ash258
Copy link
Contributor

Ash258 commented Jul 2, 2019

Change base branch to develop

@issaclin32 issaclin32 changed the base branch from master to develop July 2, 2019 07:47
@r15ch13
Copy link
Member

r15ch13 commented Jul 2, 2019

This would result in "-ir!C:\bla\bla\"*,
but shouldn't it be "-ir!C:\bla\bla\*" or -ir!"C:\bla\bla\*"?

@issaclin32
Copy link
Member Author

issaclin32 commented Jul 2, 2019

This would result in "-ir!C:\bla\bla\"*,
but shouldn't it be "-ir!C:\bla\bla\*" or -ir!"C:\bla\bla\*"?

Changing it to -ir!"C:\bla\bla\*" now. Thanks for the suggestion.

@issaclin32 issaclin32 changed the title decompress.ps1: fix bugs on extract_dir fix(decompress): fix bugs on extract_dir Jul 17, 2019
@Luckz
Copy link

Luckz commented Jul 24, 2019

I'd still really like to install ISLC some day 🥇

@r15ch13 r15ch13 merged commit 544e609 into ScoopInstaller:develop Jul 24, 2019
@issaclin32 issaclin32 deleted the fix-decompress branch July 25, 2019 01:41
Ash258 pushed a commit to Ash258/Scoop-Core that referenced this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants