Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(depends): Check if extractor is available #4042

Merged
merged 3 commits into from
Jan 8, 2022
Merged

fix(depends): Check if extractor is available #4042

merged 3 commits into from
Jan 8, 2022

Conversation

mgziminsky
Copy link
Contributor

script_deps wasn't checking if helpers were already installed before adding them as a dependency. This could cause issues if you had any of the helpers installed globally then tried installing something that depends on them to the user account.

Ash258 added a commit to Ash258/Scoop-Core that referenced this pull request Oct 28, 2020
@rashil2000 rashil2000 changed the base branch from master to develop January 8, 2022 10:40
@rashil2000 rashil2000 dismissed AlfredtheServa1’s stale review January 8, 2022 10:40

The base branch was changed.

@niheaven niheaven changed the title Don't automatically add helper dependencies if the helper is already installed fix(depends): Check if extractor is available Jan 8, 2022
@niheaven niheaven merged commit 25b1708 into ScoopInstaller:develop Jan 8, 2022
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants