Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkver): Use GitHub token from environment #4557

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

rashil2000
Copy link
Member

Blocker for ScoopInstaller/Main#2871

This is intentionally targeted to master, because this is an essential fix.

Relates to first part of ScoopInstaller/Main#2871 (comment). I will look at rate-limiting headers some other time. For now, this works fine.

How I tested this:

  • Ran checkver on Extras bucket: I get "Too many requests" error for around 450 manifests
  • Declared an environment variable $Env:SCOOP_CHECKVER_TOKEN
  • Ran checkver on Extras bucket: No errors this time

Copy link
Member

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but LGTM

@Ash258 Ash258 mentioned this pull request Dec 3, 2021
bin/checkver.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@rashil2000 rashil2000 merged commit 37a8869 into master Dec 3, 2021
@r15ch13
Copy link
Member

r15ch13 commented Dec 3, 2021

Updated the docker image of Excavator to make this patch live and it is running 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants