Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-search): Require files in 'bucket' dir for remote known buckets #4944

Merged
merged 2 commits into from
May 24, 2022

Conversation

amorphobia
Copy link
Contributor

Change regex in function search_remote: only matches json files inside 'bucket' directory.

Description

All known buckets store manifest json files in 'bucket' directory. Current scoop-search.ps1 use a regex that may match json files in the root directory, which is unnecessary for them. This small change let the 'bucket' directory be required.

Motivation and Context

Closes #4943

How Has This Been Tested?

  1. Run regression and all tests passed:
Tests completed in 38.78s
Tests Passed: 125, Failed: 0, Skipped: 0, Pending: 0, Inconclusive: 0
  1. Try the command in issue [Bug] scoop search for remote buckets might get irrelevant json files #4943 and got output as expected:
scoop.ps1 search markdownlint
No matches found.
  1. Run with an exist app to make sure it's not broken:
scoop.ps1 search minecraft
Results from other known buckets...
(add them using 'scoop bucket add <name>')

'games' bucket (install using 'scoop install games/<app>'):
    minecraft

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@chawyehsu chawyehsu changed the title fix(scoop-search): require files in 'bucket' dir for remote known buckets fix(scoop-search): Require files in 'bucket' dir for remote known buckets May 24, 2022
@chawyehsu chawyehsu merged commit 8140a20 into ScoopInstaller:develop May 24, 2022
@niheaven
Copy link
Member

Though this is merged, the changelog entry has error... Please use PR number, not issue number, in changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants