fix(update): Prevent uninstall when update #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only solution to this problem is when you download scoop using irm get.scoop.sh | iex , download version with .git file. |
rashil2000
reviewed
May 26, 2022
remove git command print Co-authored-by: Rashil Gandhi <46838874+rashil2000@users.noreply.github.com>
chawyehsu
previously approved these changes
May 29, 2022
niheaven
requested changes
May 29, 2022
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Line: 93 contain trailing whitespace
|
It should be okay, I'll test it soon. |
niheaven
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When user update scoop for the first time and meet network changes or folder in use. the program would delete whole scoop folder.
And I use Rename-Item instead of Remove-Item to prevent this.
line 77 Test-Path "$newdir\bin\scoop.ps1" is to prevent download using a wrong SCOOP_REPO with no scoop file there.
Motivation and Context
In #3050 there might be some small error caused by bucket but result in remove the whole scoop folder.
So instead of just remove current folder, I rename current folder to old and then delete old folder.
Relates to #4005
Relates to #3050
How Has This Been Tested?
remove .git folder in %scoop%\apps\scoop\current
then run scoop update
and if you open a folder in explorer like %scoop%\apps\scoop\current\libexec
folder in use and go into catch sentence
Checklist:
developbranch.