Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builds(checkver): Load page content before running 'script' #5080

Merged
merged 2 commits into from
Aug 5, 2022
Merged

builds(checkver): Load page content before running 'script' #5080

merged 2 commits into from
Aug 5, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Aug 4, 2022 •
edited
Loading

Description

Load checkver.url's page content before running checkver.script and $page variable could be used in the script.

Motivation and Context

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven niheaven mentioned this pull request Aug 4, 2022
Merged
@niheaven niheaven changed the title fix(checkver): Load page content before running 'script' builds(checkver): Load page content before running 'script' Aug 5, 2022
@niheaven niheaven merged commit f945e20 into develop Aug 5, 2022
@niheaven niheaven deleted the fix-checkver branch August 5, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashil2000 rashil2000 rashil2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niheaven @rashil2000