Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoupdate): Fix bug that 'WebClient' doesn't auto-extract 'gzip' #5901

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Apr 17, 2024

Description

When accessing 'www.python.com', WebClient does not automatically extract gzip. This pull request checks if the downloaded content is a gzip file and extracts it.

PS. We could use Invoke-WebRequest instead of WebClient to download web pages and other files.

Motivation and Context

How Has This Been Tested?

image

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@tech189
Copy link
Member

tech189 commented Apr 17, 2024

Thanks for this!

Copy link
Member

@tech189 tech189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Powershell 7.4.1 and Powershell 5

@niheaven niheaven merged commit 98cf8ae into develop Apr 17, 2024
2 checks passed
@niheaven niheaven deleted the fix-checkver branch April 17, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants