Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies and methods #153

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

mds1
Copy link
Collaborator

@mds1 mds1 commented Apr 5, 2021

Closes #152

(branched off #151, so figured we can just merge this into 151's branch first since this will be a much quicker PR to review/merge)

@mds1 mds1 requested a review from apbendi April 5, 2021 02:16
@paulmillr
Copy link
Contributor

seems like this doesn't help much judging from lockfile.

Well, since ethers.js wants to include noble in the next version (ethers-io/ethers.js#727, twitter), I think you'll see the real pkg size difference right after that.

@mds1
Copy link
Collaborator Author

mds1 commented Apr 5, 2021

Yea ended up being a small change. Since it's a monorepo, a good portion of the lockfile comes from dependencies of the fronted + contracts workspaces too, so elliptic and it's dependencies likely won't be removed from lockfile anytime soon. But they still should be tree-shaken out of the production umbra-js bundle, though I haven't looked into that yet

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@apbendi apbendi merged commit 767ad6a into ens-resolver-upgrade-implementation Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants