This repository has been archived by the owner on Apr 3, 2021. It is now read-only.
[DNM - WIP] - Stutter in Multiple Languages #288
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This is a WORK IN PROGRESS, so please DO NOT MERGE this at the time being.
Linked Issue: #215
Why It's Good For The Game
I am going to quote the linked issue:
I love little QoL projects. They can often turn into large undertakings that require weeks of work, but I always find it worth it. It's so satisfying to upturn all the dirt and soil and rework the code to add or change a feature that isn't big, but reaches a lot of people.
Step 1: Get the Character Setup Interface to Let Voxxy Mess With It (COMPLETEDS, YAYA!)
xjiLDqvccs.mp4
I created a #define for a species language list inside character setup ... just for two small code chunks ...
And I created known_langs to be a holder list for the languages a character knows within character setup.
When you initiate character setup, known_langs is defined with 'Galactic Common' and is assigned their species language. Whenever you change species, all species' languages are removed from known_langs and your new species' language is added. When you add or change your Secondary Language (there currently isn't a way to clear this), all Secondary Languages are removed from known_langs and your new selection is added.
When you set Disabilities, it gives you the option to set a stutter in each language in known_langs.
Step 2: Divorce Stutter from Stammer
What does this even mean, Kiyahitayika?
I-it means that Stutter is actually defined as a Combat Mechanic. In
combat.dm
.This links with issue: #274
I think a separate mechanic for the Disability here would be preferable so that we don't have to overhaul multiple files to add a "language" variable to the stutter combat mechanic proc.
Step 3: Allow the Character Setup selection of Stutter to actually SET for Multiple Languages
Great video. Doesn't actually do anything 0: Until Step 2.
Changelog
馃啈
wip: Stutter in Multiple Languages
/:cl: