Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify data contract for getting application layouts #102

Open
pling-scottlogic opened this issue Nov 10, 2023 · 1 comment
Open

Simplify data contract for getting application layouts #102

pling-scottlogic opened this issue Nov 10, 2023 · 1 comment
Assignees
@vferraro-scottlogic
Labels
enhancement New feature or request
Milestone
Layout Management

Comments

@pling-scottlogic
Copy link

Background

The GET endpoint on the application layouts resource currently returns a username along with the layout itself. The username is not needed on the frontend, so can be removed from the contract.

Work Required

  • Back end:
    • Change ApplicationLayoutController#getApplicationLayout to return an ObjectNode instead of the DTO
    • Extract the definition from the ApplicationLayout entity
      • ❓ In ApplicationLayoutController#getApplicationLayout or ApplicationLayoutService#getApplicationLayout?
    • Delete ApplicationLayoutDto
  • Front end:
    • Edit RemoteLayoutPersistenceManager#loadApplicationLayout to reflect changes above
    • Delete redundant ApplicationLayout type
@vferraro-scottlogic vferraro-scottlogic added this to the Layout Management milestone Nov 13, 2023
@cfisher-scottlogic cfisher-scottlogic added the enhancement New feature or request label Nov 15, 2023
@vferraro-scottlogic vferraro-scottlogic self-assigned this Nov 20, 2023
@vferraro-scottlogic vferraro-scottlogic linked a pull request Nov 21, 2023 that will close this issue
SLVUU-102 simplify getApplicationLayout response #120
Closed
@vferraro-scottlogic
Copy link

this change has been superseded by #129.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vferraro-scottlogic vferraro-scottlogic

Labels
enhancement New feature or request
Projects
None yet
Milestone
Layout Management
Development

Successfully merging a pull request may close this issue.

SLVUU-102 simplify getApplicationLayout response ScottLogic/finos-vuu
3 participants
@pling-scottlogic @vferraro-scottlogic @cfisher-scottlogic