Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: add selectors #49

Open
vferraro-scottlogic opened this issue Sep 20, 2023 · 0 comments
Open

Cypress: add selectors #49

vferraro-scottlogic opened this issue Sep 20, 2023 · 0 comments
Assignees

Comments

@vferraro-scottlogic
Copy link

vferraro-scottlogic commented Sep 20, 2023

Background

Current selectors are based on classnames. These should be a last resort if the framework doesn't provide other selectors. A combination of Cypress & Testing Library gives support for better selectors (like aria attributes). We should use these.

In Scope:

  • SaveLayoutDialog
  • LayoutList
  • Layout menu
    • save layout option
    • rename
    • title input
  • LeftNav options

Work Required

  • Add selectors to elements in scope which are used for the e2e test

Notes

We should consider implementing some kind of testing design pattern, like POM (Page Object Model), to encapsulate different parts of the application
E.g. rather than screenshot.cy.js defining all of the locators relevant to it, we have locators defined for each section/page of the application, which can then be used in any tests which rely on that page/section

Useful Links

https://www.testim.io/blog/end-to-end-testing-best-practices/
https://www.testim.io/blog/end-to-end-testing-guide/
https://www.lambdatest.com/learning-hub/end-to-end-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants