Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing PNG string in database #75

Closed
vferraro-scottlogic opened this issue Oct 16, 2023 · 1 comment · Fixed by #57
Closed

Storing PNG string in database #75

vferraro-scottlogic opened this issue Oct 16, 2023 · 1 comment · Fixed by #57
Assignees
Labels
spike Investigative work

Comments

@vferraro-scottlogic
Copy link

vferraro-scottlogic commented Oct 16, 2023

Background

as part of the layout manager feature we have been taking screenshots of the layouts and we are storing them as strings which are very long. We want to investigate what the best way of handling/storing PNGs is.
example length for the PNG string is 13186 characters

Time-boxed: 1 day

Outcome

  • shortlist of options with pros and cons for dealing with screenshots
  • meeting for discussing

Questions

  • format? (i.e. String, Binary)
  • compression?
  • changes to DTO?
  • same format in client side/ local storage?
@vferraro-scottlogic vferraro-scottlogic added the spike Investigative work label Oct 16, 2023
@pling-scottlogic pling-scottlogic self-assigned this Oct 18, 2023
@cfisher-scottlogic cfisher-scottlogic added this to the Layout Management milestone Oct 19, 2023
@cfisher-scottlogic
Copy link

The simple fix is to add the @Lob annotation to the screenshot field on the server side, keeping it as a String for transferal and storage. This has been implemented in #57.

A new ticket has been created off the back of a discussion about possible alternative data formats for generating, transferring and storing the screenshot. It would require too much work to explore those data formats as part of this spike, but could possibly be worth exploring in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike Investigative work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants